699799 - Don't AddRef/Release every uncollectable document before cycle collection

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

The Release adds the document to the cycle collector as a suspect, even though we know it's not collectable (that's the whole point of the code in nsCCUncollectableMarker).

Comment 1

[Andrew McCreight [:mccr8]]

Is this just going to avoid adding the document itself, due to the nsCCUncollectableMarker optimization, or will it pull in some successors of the document too?  One thing I want to look into is what exactly the large DOM-y globs that show up in the cycle collector graph actually are.  One theory I've had is that we aren't pruning out all visible documents that we should.

Comment 2

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1aab8b1485dd

Comment 3

[Peter Van der Beken [:peterv]]

(In reply to Andrew McCreight [:mccr8] from comment #1)
> Is this just going to avoid adding the document itself, due to the
> nsCCUncollectableMarker optimization

I think so, yes.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1aab8b1485dd