Closed
Bug 699925
Opened 13 years ago
Closed 13 years ago
Implement event.stopImmediatePropagation in workers
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla10
Tracking | Status | |
---|---|---|
firefox10 | - | --- |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files)
6.19 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
6.19 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
And again I forgot something from workers because idl files aren't utilized there :(
Assignee | ||
Updated•13 years ago
|
tracking-firefox10:
--- → ?
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → bugs
Attachment #572225 -
Flags: review?(bent.mozilla)
Comment on attachment 572225 [details] [diff] [review] patch Review of attachment 572225 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/workers/Events.cpp @@ +332,5 @@ > + StopImmediatePropagation(JSContext* aCx, uintN aArgc, jsval* aVp) > + { > + JSObject* obj = JS_THIS_OBJECT(aCx, aVp); > + > + Event* event = GetInstancePrivate(aCx, obj, sFunctions[0].name); Nit: you want sFunctions[1] here.
Attachment #572225 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #572227 -
Flags: review?(bent.mozilla)
Comment on attachment 572227 [details] [diff] [review] patch Thanks
Attachment #572227 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7e28b68cf25d Thank you for the quick review.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•