Closed
Bug 699937
Opened 13 years ago
Closed 13 years ago
content overpan gets stuck over panning
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox11 fixed, fennec11+)
VERIFIED
FIXED
People
(Reporter: blassey, Assigned: kats)
References
Details
Attachments
(3 files, 1 obsolete file)
85.81 KB,
image/png
|
Details | |
5.24 KB,
patch
|
cwiiis
:
review+
|
Details | Diff | Splinter Review |
2.92 KB,
patch
|
cwiiis
:
review+
|
Details | Diff | Splinter Review |
with pcwalton's patches applied I tried panning and wound up with the content stuck at the bottom of the page
Reporter | ||
Updated•13 years ago
|
Priority: -- → P1
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → kgupta
Assignee | ||
Comment 2•13 years ago
|
||
I've seen this happen as well, it happens if you fling the page into overscroll and then do a tap. The tap for some reason cancels the page snapping back, and so it gets stuck in overscroll. Happens on current birch tip as well.
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #575874 -
Flags: review?(chrislord.net)
Assignee | ||
Comment 4•13 years ago
|
||
Attachment #575875 -
Flags: review?(chrislord.net)
Comment 5•13 years ago
|
||
Comment on attachment 575874 [details] [diff] [review] (1/2) Some cleanup Review of attachment 575874 [details] [diff] [review]: ----------------------------------------------------------------- Fine of course, this variable is unused.
Attachment #575874 -
Flags: review?(chrislord.net) → review+
Comment 6•13 years ago
|
||
Comment on attachment 575875 [details] [diff] [review] (2/2) Fix for stuck-in-overpanning Review of attachment 575875 [details] [diff] [review]: ----------------------------------------------------------------- I did the same thing in my patches and I think this makes the same mistake - if you call fling like this, you need to make sure to cancel the fling timer on touch-down, otherwise you end up offsetting the velocity twice as the fling handler is still running when you start panning.
Attachment #575875 -
Flags: review?(chrislord.net) → review-
Assignee | ||
Comment 7•13 years ago
|
||
Good catch, thanks. I've moved the code to cancel the timer up to the beginning of onTouchStart.
Attachment #575875 -
Attachment is obsolete: true
Attachment #575905 -
Flags: review?(chrislord.net)
Comment 8•13 years ago
|
||
Comment on attachment 575905 [details] [diff] [review] (2/2) Fix for stuck-in-overpanning (v2) Review of attachment 575905 [details] [diff] [review]: ----------------------------------------------------------------- Looks good - I assume it's tested to work, so r+ from me!
Attachment #575905 -
Flags: review?(chrislord.net) → review+
Assignee | ||
Comment 9•13 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/be195eac506c https://hg.mozilla.org/projects/birch/rev/afc56afc464f
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 10•13 years ago
|
||
I cannot reproduce this issue on the latest fennec native build. Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111123 Firefox/11.0a1 Fennec/11.0a1 Samsung GalaxyS, Android 2.2
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•13 years ago
|
tracking-fennec: --- → 11+
Reporter | ||
Updated•13 years ago
|
status-firefox11:
--- → fixed
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•