700195 - "Assertion failure: !cx->isExceptionPending()" with isPrivilegeEnabled throwing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

Attachment: testcase (asserts fatally when loaded)

Assertion failure: !cx->isExceptionPending(), at js/src/jscntxtinlines.h:300

(Should throw an exception along the lines of "not enough arguments".)

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: return false on error

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 575353 [details] [diff] [review]
return false on error

I'm not a peer in this code, but this seems like a reasonable change. r=bholley.

NB: This entire API is going away soon.

Comment 4

[Steve Fink [:sfink] [:s:]]

(In reply to Bobby Holley (:bholley) from comment #3)
> I'm not a peer in this code, but this seems like a reasonable change.
> r=bholley.

Whoops, sorry. I didn't really pay attention to where this fix ended up.

> NB: This entire API is going away soon.

For that reason, and because it's such a simple fix, and because I'm a bad person, I think I'll land it anyway.

Comment 5

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d048ad9ebe24

looked good on try: https://tbpl.mozilla.org/?tree=Try&rev=51ba3fc4f12f

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/d048ad9ebe24