700277 - nsWindow::BringToFront doesn't handle first opened window properly

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Neil Deakin]

Attachment: confirm the active window with the focus manager

There is a check that returns early if the window to raise is the current top window, but that check simply looks to see if the window is first in the window list. The means that the very first window will be first in the list but can't be brought to the front, meaning that the focus manager never gets informed of its existence.

Conveniently, the first window currently is always the hidden window, no noticeable issue occurs. However, when the hidden window is removed, this causes a bug when the first window never focuses, preventing, for example, the keyboard from appearing.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Just a note, that this fix will help us remove the need for a HiddenWindow on Android, which should improve startup speed.

Comment 2

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/31328657b6d6