700331 - Remove inspectstyle() from the Web Console

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Mihai Sucan [:msucan]]

We now have the Style Inspector in the Inspector/Highlighter feature - we can remove inspectstyle() from the Web Console.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: [in-fx-team] proposed patch

Proposed patch.

Please let me know if I forgot something. Thanks!

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 572548 [details] [diff] [review]
[in-fx-team] proposed patch

I think this is good, though a little fuzzy on our rules for l10n changes in aurora. Should be OK, but let's ask Axel if this is something we can do or not.

Comment 3

[Mihai Sucan [:msucan]]

Thank you Rob for the r+!

Nominating this bug for Firefox 10 aurora.

Impact: low. This patch removes a Web Console function named inspectstyle(). Users have to know it exists.

Risk: low. This patch simply removes code and should not cause regressions.

Benefits: inspectstyle() opens the Style Inspector in a xul:panel that is generally buggy. Given the Style Inspector is now much more usable from the Inspector/Highlighter feature, we should only allow that usage pattern. This is also less code maintenance for us.

Please let me know if you have further questions/unanswered concerns regarding the patch. Thank you!

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 572548 [details] [diff] [review]
[in-fx-team] proposed patch

Review of attachment 572548 [details] [diff] [review]:
-----------------------------------------------------------------

For Aurora, we just shouldn't land the string removal, and let that cycle through in the next iteration. The strings are already on aurora, so we're not winning a lot by adding noise by removing the post merge.

Comment 5

[Mihai Sucan [:msucan]]

Attachment: patch for aurora

Patch for Aurora, without the string removals.

Thanks for the r+ Axel!

Comment 6

[LegNeato]

Comment on attachment 574630 [details] [diff] [review]
patch for aurora

[triage comment]
Approved for aurora. If it had l10n impact, it would not have met the criteria and would have been denied. Please land on aurora asap.

Comment 7

[Mihai Sucan [:msucan]]

Thank you Christian for your approval!

Comment 8

[Mihai Sucan [:msucan]]

Comment on attachment 572548 [details] [diff] [review]
[in-fx-team] proposed patch

Pushed to fx-team:

https://hg.mozilla.org/integration/fx-team/rev/2f764f3724d8

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/mozilla-central/rev/2f764f3724d8

Comment 10

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c26ec3276c1e

Comment 11

[Paul Silaghi, QA [:pauly]]

Could you please tell me how to test this ?

Comment 12

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Sure, simply open the web console and type:
inspectstyle(document.body)

If all is well you should be informed that inspectstyle is not defined.

Comment 13

[Paul Silaghi, QA [:pauly]]

Based on comment 12, this is verified fixed on Firefox 10 Beta1:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0) Gecko/20100101 Firefox/10.0