700348 - fix showBookmarkDialog warnings

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Looks like I forgot to pass into the window handle, that works regardless thanks to a compatibility shim, but complains loudly in the Error Console :(

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

this adds the missing argument

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 572896 [details] [diff] [review]
patch v1.0

Review of attachment 572896 [details] [diff] [review]:
-----------------------------------------------------------------

r=me w/ question addressed

::: browser/components/sidebar/src/nsSidebar.js
@@ +115,5 @@
>                                                         , "loadInSidebar" ]
>                                           , uri: uri
>                                           , title: aTitle
>                                           , loadBookmarkInSidebar: true
> +                                         }, win);

why changing minimal ui param here?

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Dietrich Ayala (:dietrich) from comment #2)
> why changing minimal ui param here?

it's a compatibility shim for addons, actually the method figures itself if it's minimalui bu checking if the folderPicker is in hiddenrows. We are not addons :)

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e2b0e520559

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9e2b0e520559