700498 - Clean up some StringBuffer helper methods

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

append doesn't need to take a JSAtom*, it can just take a JSLinearString*.  That lets us not try to linearize strings that are known to be linear but which aren't also atoms.

Comment 1

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ee634818139

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 572669 [details] [diff] [review]
Patch

I may have a branch patch or two which will build upon these changes, so it would be helpful to me if this were also landed on branches.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7ee634818139

Comment 5

[Alex Keybl [:akeybl]]

[Triage Comment]
Since this has been requested for both aurora and beta, and is in a sensitive area of code, would you mind providing a risk assessment? If considered low-risk, we'll try to approve for landing this week.

Comment 6

[Jeff Walden [:Waldo]]

It's low-risk -- the code's short and easy to understand, and the changes are simple.

Note that this landed before the merge, so it's already in mozilla-aurora, which I guess means this request is only for mozilla-beta.

Comment 7

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

Marking sec-review-needed per email from akeybl

Comment 8

[LegNeato]

Comment on attachment 572669 [details] [diff] [review]
Patch

[triage comment]
Approved for beta. Please land as soon as possible.

Comment 9

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/releases/mozilla-beta/rev/56f23b76a678

Thanks for working with me regarding comment 2!

Comment 10

[u279076]

Normally we would QA- code-cleanup bugs, but based on other comments in this bug I am wondering if there is anything special QA needs to verify.

Comment 11

[Alex Keybl [:akeybl]]

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #10)
> Normally we would QA- code-cleanup bugs, but based on other comments in this
> bug I am wondering if there is anything special QA needs to verify.

[Triage Comment]
Would somebody mind addressing Anthony's question by tomorrow at 12:00PM PT 12/14? We will be holding our FF9 sign-offs later that afternoon, and need to be able to verify. Thanks!

Comment 12

[Jeff Walden [:Waldo]]

Oops, sorry, missed this at the time.

I'd say probably not.  The patch is small enough that simply by observation it's fine.  And the compiler may end up being smart enough to see through the changes here and make things work most optimally anyway, depending.  So take your time with trickier changes than this, I think.

Comment 13

[u279076]

QA- based on comment 12.