700517 - Add "ret imm16" instruction for x86 and x86-64.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicolas B. Pierron [:nbp]]

IonMonkey has wrapper functions around C/C++ function calls.  Arguments are pushed to these wrappers and the wrappers are in charge of getting rid of the space reserved for the arguments, to reduce the space consumed inside the Jitted code.

Currently, a hack is done to unwind the arguments and copy the return address at the top level.  The "ret imm16" handle such case and we should use it to unwind list of arguments known at compile time.

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: MC patch, Add retn.

Comment 2

[Nicolas B. Pierron [:nbp]]

Attachment: IM patch, Add retn.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 572698 [details] [diff] [review]
IM patch, Add retn.

Review of attachment 572698 [details] [diff] [review]:
-----------------------------------------------------------------

Prefer if this was named "retn" instead to match Intel syntax, but this is not a strong preference.

Comment 4

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/?tree=Try&rev=73b8ab2861e1

Will push tomorrow presuming green :-)

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 572696 [details] [diff] [review]
MC patch, Add retn.

https://hg.mozilla.org/mozilla-central/rev/e3eaae25901c