700753 - add Open Web App support to Case Conductor

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: MozTrap, enhancement)

Description

[Cameron Dawson [:camd]]

need to add this support after the django migration

Comment 1

[Cameron Dawson [:camd]]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/20749711

Comment 2

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to started in Pivotal Tracker

Comment 3

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
note: this work is being done in a branch named "openwebapp"

Comment 4

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
ends up there's no branding for that yet.  it's still quite new (a labs project).  So can we whip up something simple for it?  Like just an image that says "Mozilla OWA" or something?  Whatever is really fine.  Eric, go crazy with it!  :)

Comment 5

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
taking this back.  apparently an OWA guy will contact me about an image

Comment 6

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
confirmed there is no OWA branding for now.  We can just use the mozilla logo or something.  Even a button with text and no picture for now is fine.

Comment 7

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
jonny and eric: OK, I added the template tag.  This is my first one, so I hope I did this right.  Can you check it and see if that works for you?  thanks!  Pushed to the openwebapp branch.

Comment 8

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
Just a question: now that this is here, can I remove the view for registering?  I still need one for the manifest, I presume.

Comment 9

[Cameron Dawson [:camd]]

Jonny Gerig Meyer added a comment in Pivotal Tracker:   
   
Ok, the new JS is in place, so I assume the old self_register view and template can be removed now.

When I test locally, I get an error:

502 Bad Gateway
Bad gateway.
URL returned error code: 503

Is that to be expected?

Comment 10

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
Jonny: yeah, I think so if you're running it at localhost:8000.  I have to run it from another server to get it to work.

Comment 11

[Cameron Dawson [:camd]]

Jonny Gerig Meyer added a comment in Pivotal Tracker:   
   
I went ahead and removed the old self_register view and template, so I'll pass this to Carl for code review and merging.

Comment 12

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
thanks Jonny!

Comment 13

[Cameron Dawson [:camd]]

Carl Meyer changed story state to delivered in Pivotal Tracker

Comment 14

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
I'll test and approve this as soon as it's up on the dev site

Comment 15

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
Jonny,  the OWA call should return a pass or fail status.  At the moment, if it succeeds, the user doesn't see anything saying so.  The dialog just goes away (give it a shot on caseconductor-dev.)  I think a green or red message on top saying yay or nay is necessary.

Comment 16

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to rejected in Pivotal Tracker

Comment 17

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
btw: you can test this on master by installing this addon for firefox: http://people.mozilla.com/~dclarke/openwebapps/Extension/latest/openwebapps.xpi

After installed, (and click button from caseconductor-dev) then click the "Apps" item on the addon toolbar at the bottom.  Or type "about:apps" in the toolbar to see it listed.

Comment 18

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
Apparently this won't required an add-on after Firefox 13 or something...

Comment 19

[Cameron Dawson [:camd]]

Jonny Gerig Meyer changed story state to started in Pivotal Tracker

Comment 20

[Cameron Dawson [:camd]]

Jonny Gerig Meyer added a comment in Pivotal Tracker:   
   
Cam: I'm a bit stumped here, to be honest. It looks to me like a bug in the Apps API javascript library (https://myapps.mozillalabs.com/jsapi/include.complete.js), such that the callbacks (onsuccess or onerror) are never being called, regardless of the success/failure of the OWA installation. I hacked the code a bit and was able to get the onerror callback to work properly (locally; I didn't push this), but I'm still not sure why the onsuccess callback never occurs. I seem to be calling the JS properly, at least according to the docs: https://developer.mozilla.org/en/Apps/Apps_JavaScript_API/navigator.mozApps.install

Is there anyone there working on OWA who could help us out, or just confirm that a) the code works properly for other people, and b) the docs are up-to-date?

Comment 21

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
Jonny: I wonder if things changed in that OWA JS file.  In my old view code, it was actually calling the success callback, as I was getting the alert() call on success.  But that was quite a while ago, and OWA has been a bit in flux.

I think the OWA guys would probably be happy to give us a hand, so let me check with them.

Comment 22

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
Ok, per Cam's email that OWA isn't quite ready for us in 1.0, I ripped all the OWA code out of master and back into the "openwebapp" branch. I also marked this story "not started" so it can go later in the backlog; once we're ready for it, we can get it all working in the openwebapp branch and then merge back into master.

Comment 23

[Cameron Dawson [:camd]]

Carl Meyer changed story state to unstarted in Pivotal Tracker

Comment 24

[Cameron Dawson [:camd]]

Jonny Gerig Meyer added a comment in Pivotal Tracker:   
   
Cam: With Ian's info about the new API, I was actually able to get this working pretty quickly. So unless there are more changes coming, I think this branch is ready to merge back in whenever you're ready. (If you still want to put it off, that's fine. I just wanted to note that it seems to be working fine, with the proper notifications, etc.)

Comment 25

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to started in Pivotal Tracker

Comment 26

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
Jason says the api is now solidified and ready for us to use.  I'll play with this and see if it's still working.

Comment 27

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to finished in Pivotal Tracker

Comment 28

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to accepted in Pivotal Tracker

Comment 29

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to accepted in Pivotal Tracker

Comment 30

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-closing remaining MozTrap bugs as WONTFIX, due to 1) the Mozilla-hosted instance being decommissioned (see https://wiki.mozilla.org/TestEngineering/Testrail), and, for now, 2) the still-up code archived at its GitHub page: https://github.com/mozilla/moztrap (we'll decide what's next for that, in the near future).

See also the history and more-detailed discussion which led us here, at https://groups.google.com/forum/#!topic/mozilla.dev.quality/Sa75hV8Ywvk

(If you'd like, you should be able to filter these notification emails using at least the unique string of "Sa75hV8Ywvk" in the message body.

Thanks!