700993 - Chrome tabs broken after landing of bug 677421

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jonathan Protzenko [:protz]]

Attachment: Patch

Opening chrome tabs is broken. shouldSwitchTo expects a contentPage property, when forwarding the call from the chrome tab type, the parameter is named chromePage, not contentPage.

Comment 1

[Jim Porter (:squib)]

Comment on attachment 573162 [details] [diff] [review]
Patch

Good catch! This looks ok to me, assuming you've tested that it works.

Comment 2

[Jonathan Protzenko [:protz]]

Yep. Tested that it works :). Thanks for the quick review!

http://hg.mozilla.org/comm-central/rev/b09edfb0a96b

Comment 3

[Jonathan Protzenko [:protz]]

http://hg.mozilla.org/releases/comm-aurora/rev/5de7b954c1eb

Mark, can you make sure I did the right things with flags? Thanks :)

Comment 4

[Mark Banner (:standard8)]

(In reply to Jonathan Protzenko [:protz] from comment #3)
> Mark, can you make sure I did the right things with flags? Thanks :)

Leave the tracking alone, just mark the status as fixed (its only if tracking ver == trunk ver that I tend to cancel that flag due to the tools being not quite good enough).