70112 - Move "About Mozilla" from properties to dtd

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Peter "jag" Annema]

This means we can remove helpMenuCreate() from utilityOverlay.js, but it also
means changing the Mac code which now reads from that properties file to instead
get the label from the menuitem.

Attaching a few patches soon.

Comment 1

[Peter "jag" Annema]

Attachment: [patch] This should make Mac use the menuitem's label.

Comment 2

[Peter "jag" Annema]

Note: the above patch is completely untested, I wouldn't mind some Mac help,
cc'ing saari.

Attaching patches for the XP part.

Note2: once those patches are applied, the first patch should be changed to also
do s/releaseName/aboutName/

Comment 3

[Peter "jag" Annema]

Attachment: [patch] XP part + fixing mac/nsMenu.cpp

Comment 4

[Peter "jag" Annema]

Attachment: [patch] Remove aboutStrName from brand.properties once above two patches are applied

Comment 5

[Peter "jag" Annema]

timeless noted that when releaseUrl was moved from brand.properties to
region.properties it was incorrectly changed from
<http://www.mozilla.org/releases/> to
<http://www.mozilla.org/projects/seamonkey/release-notes/>

I'll undo that change before checking in.

Comment 6

[timeless]

r=timeless given that assurance.

Comment 7

[Peter "jag" Annema]

So it seems like the first patch needs to #include "nsHTMLAtoms.h" to work and
the .mcp will probably need to be modified to add an include path directly to
the source dir (this is what other places / unix makefiles seem to do).

Currently it will put "About" in the Mac help menu, but with patch 2 applied and
changing "releaseName" to "aboutName" in patch 1 it should say "About Mozilla"
or "About Netscape 6".

"Should" being the operative word here. If someone could confirm this for me
I'll attach the new patch.

Comment 8

[Mike Pinkerton (not reading bugmail)]

i had to make some (minor) changes to the patches, but after doing that, this
worked on mac. 

Comment 9

[Peter "jag" Annema]

Attachment: [patch] update to attach_id=26147, make mac use menuitem value

Comment 10

[Peter "jag" Annema]

Attachment: [patch] a second attempt at that...

Comment 11

[Peter "jag" Annema]

Attachment: [patch] add/improve comments in nsMenu(Bar).cpp

Comment 12

[saari (gone)]

looks good to me, r=saari

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 14

[Peter "jag" Annema]

Attachment: [patch] merging all above patches into one to make life easier

Comment 15

[Peter "jag" Annema]

okay, checked in, marking fixed.

Comment 16

[sairuh (rarely reading bugmail)]

rubberstamp.