701216 - [homepage] Some teams are missing a real name

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect)

Description

[Peter Bengtsson [:peterbe]]

For example, on https://l10n-stage-sj.mozilla.org/teams/af it says::

 <h1>Mozilla Localization Team None</h1>

Comment 1

[Peter Bengtsson [:peterbe]]

Correction: they're all missing it.

Comment 2

[Peter Bengtsson [:peterbe]]

Half-way through doing the hotfix I figured out it's because django_compressor somehow overrides the template context variable 'name'. Not cool :(

https://github.com/jezdez/django_compressor/issues/156

Comment 3

[Axel Hecht [:Pike]]

yikes. are there more variables it uses?

Comment 4

[Peter Bengtsson [:peterbe]]

Attachment: referencing locale name differently to avoid bug in django_compressor

Comment 5

[Peter Bengtsson [:peterbe]]

(In reply to Axel Hecht [:Pike] from comment #3)
> yikes. are there more variables it uses?

Nope. Looked deep into it but eventually decided it's too complex for me to try to fix it for jezdez. I'm sure he can fix it by changing "name" to "block_name". Also I don't know how to run his testsuite. 
Here's the culprit: https://github.com/jezdez/django_compressor/blob/develop/compressor/templatetags/compress.py#L81

Comment 6

[Peter Bengtsson [:peterbe]]

Landed https://github.com/mozilla/elmo/commit/52ea8e320f3a5ea8f4a08a63417f135d343423bb

Comment 7

[Peter Bengtsson [:peterbe]]

Deployed and verified.