701244 - "Assertion failure: 0,"

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

String(
    (function() {
        function k({
            d: {
                length
            }
        }) {}
    }), "\
    (function() {\
        function k({\
            d: {\
                length\
            }\
        }) {}\
    })\
")

asserts js debug shell on m-c changeset 4fb61ebbf8ff with patch v1 from bug 697279 without any CLI arguments at Assertion failure: 0,

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   79903:a6c390aa3bf2
user:        Luke Wagner
date:        Mon Nov 07 11:46:25 2011 -0800
summary:     Bug 696813 - Simplify Decompile (r=waldo)

Comment 1

[Luke Wagner [:luke]]

Attachment: fix

Mmm destructuring.

Comment 2

[Luke Wagner [:luke]]

Attachment: fix

Oops, patch should not include nsJSEnvironment hackery...

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 573396 [details] [diff] [review]
fix

Low-risk fix (backing out overzealous removal).

Comment 4

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7d2f71b4c87

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/b7d2f71b4c87

Comment 6

[Luke Wagner [:luke]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dc811a039a7a

Comment 7

[Mihaela Velimiroviciu (:mihaelav)]

OS; Mac OS X 10.6

I used the beta source with the latest revision (mozilla-beta-226c1a05e0b6) and built the js debug shell; then I run the test from comment #0 (./js testcaseFile) and no message was displayed. 
Is this what was needed to verify this issue?
Thanks!

Comment 8

[Christian Holler (:decoder)]

(In reply to Mihaela Velimiroviciu [QA] from comment #7)
 
> Is this what was needed to verify this issue?

Yes that sounds alright. In general if you are not sure if you're testing correctly, try building the debug shell in both the most current and unfixed revisions to see the assertion going away :)

Comment 9

[Mihaela Velimiroviciu (:mihaelav)]

Setting VERIFIED based on previous comment. Thank you!

Comment 10

[Christian Holler (:decoder)]

A testcase for this bug was automatically identified at js/src/jit-test/tests/basic/testBug701244.js.