701260 - Deny requests for DOM full-screen when windowed plugins are present in the entire doc tree

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Currently the check which prevents us going full-screen when a doctree contains a windowed plugin only checks the document and its subdocuments, whereas it should check every document in the target document's branch (but not in other branches/tabs).

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Change to deny requests for full-screen if any doc in the tab has a windowed plugin, rather than if the requesting doc or its subdocs have windowed plugins.

I have tests, but the tests leak on tryserver (even without this patch applied!), so I'll not put the tests up for review.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67d6b8636246

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/67d6b8636246

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 574747 [details] [diff] [review]
Patch

Requesting approval for Aurora, because this fix prevents a work-around which enables keyboard input in full-screen mode which doesn't cause the "Press ESC to leave full-screen mode" warning to pop up. We need this to help protect against phishing attacks.

Comment 5

[LegNeato]

Comment on attachment 574747 [details] [diff] [review]
Patch

[triage comment]
Approved for aurora. Please land as soon as possible

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/43e4a46ca7dc

Comment 7

[u279076]

Is this something QA can verify?

Comment 8

[u279076]

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #7)
> Is this something QA can verify?

bump