701366 - in awesomescreen, horizontal swiping should switch between categories

Status: RESOLVED DUPLICATE of bug 759041

(Firefox for Android Graveyard :: General, defect, P5)

Comment 1

[Madhava Enros [:madhava]]

Hm. That went through without a description. :(

As seems to be standard on ICS, side-to-side swiping in the awesomescreen should switch between the categories (All, Bookmarks, History, etc.).

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Madhava Enros [:madhava] from comment #1)
> Hm. That went through without a description. :(
> 
> As seems to be standard on ICS, side-to-side swiping in the awesomescreen
> should switch between the categories (All, Bookmarks, History, etc.).

Do we know if this is "standard"/built-in feature for any TabHost on ICS? If it is, then I think we do nothing. We don't need to backport Android features to older versions of Android.

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> (In reply to Madhava Enros [:madhava] from comment #1)
> > Hm. That went through without a description. :(
> > 
> > As seems to be standard on ICS, side-to-side swiping in the awesomescreen
> > should switch between the categories (All, Bookmarks, History, etc.).
> 
> Do we know if this is "standard"/built-in feature for any TabHost on ICS? If
> it is, then I think we do nothing. We don't need to backport Android
> features to older versions of Android.

ICS' source code is not available yet so I have no way to confirm that but, AFAIK, yes, TabHost in ICS has swipe gesture support by default.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's wait until we know the story with ICS

Comment 5

[Gian-Carlo Pascutto [:gcp]]

So what's the story on ICS? I'm missing this gesture, as it feels very natural.

Comment 6

[Lucas Rocha (:lucasr)]

(In reply to Gian-Carlo Pascutto (:gcp) from comment #5)
> So what's the story on ICS? I'm missing this gesture, as it feels very
> natural.

We need to include the Android support package in our APK to get ViewPager and fragments support support that is backwards-compatible with Android >= 1.6. Then it's just a matter of re-structuring the awesomebar screen to use those APIs.

My assumption above (comment #3) was unfortunately wrong. TabHost does not give us swiping gestures support for free on ICS. We need to use a combination of tabhost (or ActionBar tabs) and ViewPager to get that.