701390 - Socorro - adjust signature generation for new Java stack field in json

Status: RESOLVED FIXED

(Socorro :: Backend, task)

Description

[K Lars Lohn [:lars] [:klohn]]

The current processor signature generation code expects Java stack info to be in the AppNotes field.  Soon, that data will move to its own field within the json. When this change lands in Breakpad, Socorro must change too.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This field needs to be searchable as well.  hence blocks 718820

Comment 2

[Robert Kaiser]

(In reply to Naoki Hirata :nhirata from comment #1)
> This field needs to be searchable as well.  hence blocks 718820

Not sure what you mean with "searchable". For one thing, signatures need to be generated from it, sure, that's this bug. And signatures can be searched well anyhow.
For the other, I think in search, the new field should be treated similarly to frames further down the stack than the signature. Once we know more about what's coming implementation-wise here (before that we can't act on anything), i.e. once bug 701002 comes along, we might need a couple dependencies for different details like search, listing in our exported CSVs, etc. - but those only make sense once we know what the client side will be doing and what the field will be called in Socorro.

Comment 3

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/897d4ddb955b11b0a7f3893b2d3f89780e8e654b
Merge pull request #295 from twobraids/Bug701390-JavaSig

add new Java signature algorithm

Comment 4

[K Lars Lohn [:lars] [:klohn]]

Attachment: a Fennec crash that deserves a Java signature

this now merged.  I've attached a Java crash pair that demonstrates the correctness of this patch.  

The signature generated by this crash should be:

  "java.lang.RuntimeException: CPETERSON BUG701002 TEST at org.mozilla.gecko.GeckoApp.doReload(GeckoApp.java)"

single spaces between all words, no line feeds.