701493 - wrap save and restore code at both window and tab levels in try{} blocks

Status: RESOLVED WONTFIX

(Firefox :: Session Restore, defect)

Description

[Dietrich Ayala (:dietrich)]

yes, a hack. but will effectively remove any chance that a whole session is lost due to problems with a single window or tab.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Nah.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

I find the idea interesting. Do we have actually know of cases in which session collection/restoration triggers an error?

If so,

try {
  ...
} catch (ex) {
  Promise.reject(ex);
  // Ensure that tests fail, errors are reported, but users can continue
}

could indeed prevent data loss.

Comment 3

[Dietrich Ayala (:dietrich)]

It doesn't matter if we do or don't.

It's a Rumsfeldian situation where we're protecting against unknown unknowns in order to prevent dataloss, which should trump all notions of propriety wrt adding hacks to our codebase ;)

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

True, but in today's world where the restoration and collection part run in frame scripts on the content side there basically is only a single tab that can fail to be restored or some part of the tab's data can't be collected. We're luckily not a big function anymore that as a whole fails or succeeds. OTOH, When wrapping everything in try/catch and just logging to the console there might be cases where users don't even notice something's wrong and we'll never see a bug about it.