701516 - use httpd module to start running test-request.js tests again

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

A bunch of tests in test-request.js are commented out because they require a network connection.  Now that we have the httpd module, we should use it to provide a local server for those tests so we can start running them again.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I can work on this tomorrow.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Link to pull request 259

Here's about half of the request tests turned back on and adjusted to use the new httpd server module.

The remaining tests require the original php files from Zpao's webserver, so I'm waiting for those before going any further.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 573700 [details]
Link to pull request 259

A few issues, a few nits, all noted in the pull request.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 573700 [details]
Link to pull request 259

Comments addressed; re-requesting review.

Comment 5

[[github robot]]

Commit pushed to https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a138a8085b8f8f585d497967fed08ccc66ccf3ed
Merge pull request #259 from KWierso/test-requests

fix bug 701516 - Use httpd module to serve files for newly re-enabled request tests. r=@mykmelez