701666 - Removing TxObject define and Double typedef from xslt

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

content/xslt/src/base/txCore.h has '#define TxObject txObject'. It would be better if code used the latter form instead.

See

http://mxr.mozilla.org/mozilla-central/ident?i=TxObject&tree=mozilla-central&filter=&strict=1

Comment 1

[Atul Aggarwal]

Attachment: Patch v1

Removing the TxObject define as well removing the Double typedef. Patch is somewhat long but it requires only a glance.

Comment 2

[Atul Aggarwal]

https://tbpl.mozilla.org/?tree=Try&rev=4c3f4eeda2c3

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 575408 [details] [diff] [review]
Patch v1

>--- a/content/xslt/src/xslt/txNodeSorter.h
>+++ b/content/xslt/src/xslt/txNodeSorter.h
>-    static bool calcSortValue(TxObject*& aSortValue, SortKey* aKey,
>+    static bool calcSortValue(txObject*& aSortValue, SortKey* aKey,
>                                 SortData* aSortData, PRUint32 aNodeIndex);

Reindent the next line while you're here.

Looks good to me, but I'd like Jonas' sign-off.

Comment 4

[Atul Aggarwal]

Attachment: Patch v1.01

Change suggested by Ms2ger. (I did the change using sed and hence missed it :))

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 575442 [details] [diff] [review]
Patch v1.01

For patches like this, it's nice if you can attach the script (or list of commands) used to create the patch, in addition to the patch itself.

It's easier to review the script for correctness...

r=me though :)

Comment 6

[Atul Aggarwal]

Thanks Jonas for the review. I will take care of it from next time.

Comment 7

[Ed Morley [:emorley]]

In my queue with a few other bits that are being sent to try first and then onto inbound :-)

https://tbpl.mozilla.org/?tree=Try&rev=eb96679e6888

Comment 8

[Ed Morley [:emorley]]

Bug 687511 included in that try run failed check-sync-dirs, so had to push again:

https://tbpl.mozilla.org/?tree=Try&rev=329bc2d383a3 
(this changeset is there, is just hidden due to the previous push to try)

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7bbdb6243033

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7bbdb6243033