701839 - Wrong favicon displayed when both default location and link exists

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I noticed that the favicon for a Google Code project is using the default favicon for the domain instead of the one specified by the <link> tag.

Steps to reproduce:
1. Open http://code.google.com/p/selenium/

Expected result:
Favicon displayed in awesomebar should be http://www.gstatic.com/codesite/ph/images/phosting.ico

Actual result:
Favicon displayed in awesomebar is http://code.google.com/favicon.ico

Comment 1

[John Hammink]

Confirmed on Android 3.1  (Samsung Galaxy Tab 10.1);
and Android 3.2  (Asus Transformer)

Comment 2

[John Hammink]

What's more I'm seeing a new issue where content is not actually shown when surfing to the above page.  Entered as:

https://bugzilla.mozilla.org/show_bug.cgi?id=701906

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: patch

It looks like the issue may be caused by this Android bug: http://code.google.com/p/android/issues/detail?id=6066

This patch fully downloads the image before creating a Drawable.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 574431 [details] [diff] [review]
patch

Brian, were you able to reproduce the issue and then see this patch fix it?

r+ if we are sure this was the cause and it's fixed now.

Comment 5

[Brian Nicholson (:bnicholson)]

Yes; Drawable.createFromStream() was returning null for me (and preventing this specific favicon from loading).  After changing the code to download the entire image first, the favicon loads as expected.

Comment 6

[Brian Nicholson (:bnicholson)]

Landed http://hg.mozilla.org/projects/birch/rev/3394b9626828

Comment 7

[Catalin Suciu [:csuciu]]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111117 Firefox/11.0a1 Fennec/11.0a1
Device: Galaxy S
OS: Android 2.2

Comment 8

[Catalin Suciu [:csuciu]]

Sorry, this is the actual build:
Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111120 Firefox/11.0a1 Fennec/11.0a1