701994 - Tab counter animation should show overlapping of numbers

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Sriram Ramasubramanian [:sriram]]

As per the UI spec, the tab counter animation should show overlapping of numbers.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

I tried re-implementing TextSwitcher as a Odometer. This moves all the logic to a new file and does the overlap.
The magic was in setting the amount to displace (currently 30%) :sigh: :( :(

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

If "the amount to displace" was the "magic" for showing a overlap, I was wondering if that would work with TextSwitcher also.

Strangely it does!! :(
After 2 hours of working on the previous patch, I figured out it takes just 4 line change in existing code to achieve the same effect! :big-sigh: :(

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/859ecdfe0168

Comment 4

[Aaron Train [:aaronmt]]

Neat.

Sririam, did you file a bug for tweaking the animation speed?

20111115040200
http://hg.mozilla.org/projects/birch/rev/97283e503e1e