702144 - Scratchpad russian codepage

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Andrew]

Attachment: 76867.png

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0
Build ID: 20111109112850

Steps to reproduce:

Scratchpad - File - Open File - [e-mail] (utf-8) - see screen-shot (76867.png)


If i write in clear Scratchpad - all normal.

Comment 1

[Andrew]

Attachment: [e-mail]

Comment 2

[Rob Campbell [:rc] (:robcee)]

Thanks for the bug report!

This looks like it works fine in Firefox 10+ with Orion enabled.

Presumably this will be a problem in Firefoxes 8-10 with the text-based source editor in place.

Comment 3

[Andrew]

Attachment: orion 11

In 8, 9, 10, 11 - same too.

Comment 4

[Rob Campbell [:rc] (:robcee)]

Strange. I'm unable to reproduce this with your attached text on my machine in OS X.

Can anyone with a Windows machine try this out?

Comment 5

[David Chan [:dchan]]

Not all the characters are displaying for me either.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a1) Gecko/20111108 Firefox/10.0a1 ID:20111108031146

OS X 10.6.8

Copying and pasting works fine. The script file also displays properly in Dashcode

Comment 6

[David Chan [:dchan]]

Attachment: convert input to UTF-8

I copied the code from exportToFile and it appears to work. We may be able to remove the manual conversion once bug 655658 lands.

Comment 7

[David Chan [:dchan]]

Attachment: convert input to UTF-8 v2

We probably want to pass the unicode version of the content to the callback. Stupid mistake

Comment 8

[Andrew]

Will be implemented by the wrap of long lines in scratchpad (style editor and other) and file://, ftp://, http://, https://, etc protocols (in default or checkbox in settings)?

Comment 9

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 574743 [details] [diff] [review]
convert input to UTF-8 v2

this looks like it should do the trick.

Comment 10

[David Chan [:dchan]]

Hmmm, looking at the documentation again. I'm not sure if converter.Finish() needs to be called when converting to unicode. It seems to work fine without it. Does anyone have more experience with nsIScriptableUnicodeConverter?

Comment 11

[David Chan [:dchan]]

Attachment: convert input to UTF-8 v3

Remove the Finish() call since it is only needed for ConvertFromUnicode() and not ConvertToUnicode()

I need help landing the patch on m-c

Comment 13

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 581829 [details] [diff] [review]
convert input to UTF-8 v3

I thought I reviewed this already. Sorry for the delay.

Comment 14

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/805facc7eb21

Comment 15

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/805facc7eb21