702225 - Implement revised nav bar button appearance on Windows

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: patch

try build: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-f16a1567c3ce/try-win32/

Comment 1

[PimpUigi]

Anyway I can look at this???

Comment 2

[Dão Gottwald [:dao]]

Stephen, could you please review this? It's ok if textures, borders etc. aren't quite perfect, as we can easily tweak them (about to happen in bug 727650).

Comment 3

[Stephen Horlander [:shorlander]]

(In reply to Dão Gottwald [:dao] from comment #2)
> Stephen, could you please review this? It's ok if textures, borders etc.
> aren't quite perfect, as we can easily tweak them (about to happen in bug
> 727650).

Yes! I will review this right now. Really sorry for the delay I have no idea how this fell off my radar.

Comment 4

[Stephen Horlander [:shorlander]]

Comment on attachment 574270 [details] [diff] [review]
patch

Review of attachment 574270 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Dão Gottwald [:dao] from comment #2)
> Stephen, could you please review this? It's ok if textures, borders etc.
> aren't quite perfect, as we can easily tweak them (about to happen in bug
> 727650).

Looks good! 

The only thing I noticed was that the #forward-button mask works on hover but distorts when pressed: http://cl.ly/1G2Z1i1F2B412r053344

Maybe fix it the same way as the hover/non-hover states?

>+  box-shadow: 0 1px 0 rgba(255,255,255,.3) inset,
>+              0 0 0 1px rgba(255,255,255,.3) inset,
>+              0 1px 0 hsla(210,54%,20%,.02),
>+              /* allows winstripe-keyhole-forward-mask to be used for non-hover as well as hover: */
>+              0 0 2px hsla(210,54%,20%,0);

+  box-shadow: 0 1px 1px rgba(0,0,0,.1) inset,
+              0 0 2px rgba(0,0,0,.3) inset,
+              /* allows winstripe-keyhole-forward-mask to be used for active as well as non-hover and hover: */
+              0 1px 0 hsla(210,54%,20%,0),
+              0 0 2px hsla(210,54%,20%,0);

Comment 5

[Dão Gottwald [:dao]]

> The only thing I noticed was that the #forward-button mask works on hover
> but distorts when pressed: http://cl.ly/1G2Z1i1F2B412r053344
> 
> Maybe fix it the same way as the hover/non-hover states?
> 
> >+  box-shadow: 0 1px 0 rgba(255,255,255,.3) inset,
> >+              0 0 0 1px rgba(255,255,255,.3) inset,
> >+              0 1px 0 hsla(210,54%,20%,.02),
> >+              /* allows winstripe-keyhole-forward-mask to be used for non-hover as well as hover: */
> >+              0 0 2px hsla(210,54%,20%,0);
> 
> +  box-shadow: 0 1px 1px rgba(0,0,0,.1) inset,
> +              0 0 2px rgba(0,0,0,.3) inset,
> +              /* allows winstripe-keyhole-forward-mask to be used for
> active as well as non-hover and hover: */
> +              0 1px 0 hsla(210,54%,20%,0),
> +              0 0 2px hsla(210,54%,20%,0);

done

http://hg.mozilla.org/integration/mozilla-inbound/rev/8bca9af04102

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8bca9af04102

Comment 7

[Siddhartha Dugar [:sdrocking]]

@Dao: Is there a bug filed for the Panorama button becoming white with dark personas when on the navigation toolbar (with large icon mode and tabs on top)?