702532 - Unnecessary preprocessing in the devtools jar manifest

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

From the 3 files that are marked for preprocessing in browser/devtools/jar.mn, only scratchpad.xul looks like it needs it and that one could probably do without the #ifdef 0 to hide a comment block:

*   content/browser/inspector.html                (highlighter/inspector.html)
*   content/browser/scratchpad.xul                (scratchpad/scratchpad.xul)
*   content/browser/scratchpad.js                 (scratchpad/scratchpad.js)

Hopefully this would shorten build times by a tiny fraction, which might be non-trivial for tinderboxes.

Comment 1

[Cedric Vivier [:cedricv]]

Attachment: patch v1

Let's do it ;)
More importantly it avoids surprises when using --enable-chrome-format=symlink.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

I remember I had problems when I filed the bug getting a functional build after clobbering. Does this patch work after building from a clean slate? A try run should be sufficient, too.

Comment 3

[Justin Dolske [:Dolske]]

Comment on attachment 596480 [details] [diff] [review]
patch v1

Unassigned review! Sending to... *spins wheel* dcamp!

Please review/reassign/close as appropriate.

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 596480 [details] [diff] [review]
patch v1

I dunno. Including that comment in our source file could really bloat the Firefox download size. R+ anyway.

Comment 5

[Rob Campbell [:rc] (:robcee)]

(totally stole that review from dcamp. swish.)

Comment 6

[Dave Camp (:dcamp)]

Is this ready to land?  Does it need rebasing?

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v2

Updated patch to reflect current reality. Try run:
https://tbpl.mozilla.org/?tree=Try&rev=92e3ddd476b9

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/e7f1d04c8ab1

Comment 9

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/e7f1d04c8ab1