Open Bug 702560 Opened 13 years ago Updated 2 years ago

add a11y mochitest for HTML 5 contextmenu

Categories

(Core :: Disability Access APIs, defect)

defect

Tracking

()

People

(Reporter: surkov, Unassigned, Mentored)

References

(Blocks 2 open bugs)

Details

(Keywords: access, good-first-bug)

Attachments

(3 files, 7 obsolete files)

See example in bug 617528. It works with screen readers. All we need is to make sure it's covered by mochitests suite.
add a file tree/test_contextmenu.html, see others tests in the folder (like test_map.html) to get an idea how to do that.
Whiteboard: [good first bug]
Blocks: html5a11y
Whiteboard: [good first bug] → [good first bug] [mentor=marco.zehe@googlemail.com]
Hi, I would like to work on this bug. I've fixed a few bugs before, so I'll try to figure out what needs to be done, but could someone please guide me if and when I get stuck? Thanks a lot!
Go for it!
Assignee: nobody → murali.sr92
(In reply to Murali from comment #2)
> Hi, I would like to work on this bug. I've fixed a few bugs before, so I'll
> try to figure out what needs to be done, but could someone please guide me
> if and when I get stuck? Thanks a lot!

sure, please don't hesitate to ask questions
Attached file A Rough Draft..? (obsolete) —
Could you please tell me whether I have understood correctly? 
I've passed the div to testAccessibleTree(). Should I pass the context menu to testAccessibleTree() instead? So Sorry if I'm disturbing you a lot..
Attachment #593855 - Flags: feedback?(bolterbugz)
Comment on attachment 593855 [details]
A Rough Draft..?

This is a good start, you have the basic idea.

I think what we want to do here is to simulate the usage of the context menu, and then check to make sure the accessible tree is correct. It will make this bug a bit harder to fix, but a lot more interesting and useful.

Have a look at tests/mochitest/tree/test_tree.xul for an example of how to trigger a tree test from an event. (Note that is a .xul file, but keep yours as .html, just borrow the ideas)
Attachment #593855 - Flags: feedback?(bolterbugz)
Please see bug 617528 "updated demo" attachment for some sample html context menu markup. (You don't need something this elaborate though)
Attached file Patch
Could you please verify this and let me know what change is required? Thanks a lot and sorry for the trouble.
Attachment #593855 - Attachment is obsolete: true
Attachment #595046 - Flags: feedback?(marco.zehe)
Attachment #595046 - Flags: feedback?(bolterbugz)
Comment on attachment 595046 [details]
Patch

This is correct in principle, but the syntax is

role: 

followed by the role for menu, menuitem etc. as defined in tests/mochitest/role.js, which you'll also need to include.

Note that this is only doing the test and that the menu si not part of the DOM until the element it is being pointed to is right-clicked, so you'll need to do an invoker and check the correct event check. But this is a good start since you got the principle idea of the tree right.
Attachment #595046 - Flags: feedback?(marco.zehe) → feedback+
Comment on attachment 595046 [details]
Patch

Ditto Marco.

Murali are you able to run the test to see what happens? Note we have ways to dump debugging info: http://bit.ly/vZfiRW
Attachment #595046 - Flags: feedback?(bolterbugz)
This approach is not going work because HTML5 contextmenus are integrated into Firefox contextmenu. You should show context menu and then inspect the tree (refer to events/test_contextmenu.html as example).
Hi, Could you please tell me whether my understand is correct. 

I've looked at /events/test_contextmenu.html.
Similar to that, I have to show, select and close the context menu. 
Apart from this, I should also test the tree using testAccessibleTree, similar to the patch I have submitted already.

I'm really sorry for asking so many questions. Thanks a lot!
(In reply to Murali from comment #12)
> Hi, Could you please tell me whether my understand is correct. 
> 
> I've looked at /events/test_contextmenu.html.
> Similar to that, I have to show, select and close the context menu. 
> Apart from this, I should also test the tree using testAccessibleTree,
> similar to the patch I have submitted already.

right: show menu, test the tree and close menu (optional but nice)

get context menu by getContextMenuNode() (see text_contextmenu.html) and test its tree

> I'm really sorry for asking so many questions. Thanks a lot!

don't be sorry for asking question, do not hesitate to do that
Murali, could you confirm that you're still working on this?
Flags: needinfo?(murali.sr92)
Assignee: murali.sr92 → nobody
Flags: needinfo?(murali.sr92)
Mentor: marco.zehe
Whiteboard: [good first bug] [mentor=marco.zehe@googlemail.com] → [good first bug]
Hi, I was just wondering if anyone was working on this bug because I want to take a stab at it.
(In reply to Shakthi Wijeratne from comment #15)
> Hi, I was just wondering if anyone was working on this bug because I want to
> take a stab at it.

no activity for years so far, please feel free to pick it up
Hello all. Trying to work on this bug. I wanted to know where to put the code for getting the context menu. Should it be after closing the menu or before? Because to me it didn't seem to make sense putting the getContextMenu after the context menu's been closed. From how I understand it. Your guidance is appreciated.
Flags: needinfo?(mzehe)
If the context menu closes, it goes away, so there is nothing more to get. So yes, I think your assumption is right that you have to put that before the context menu closes.
Flags: needinfo?(mzehe)
Attached file Sample test_contextmenu.html (obsolete) —
Sample test_contextmenu.html. Not too sure about how the context menu calls are arranged. I figured they should be in the order of get, show and close with testing the tree in between show and close. I've used Murali's last patch as is as regards the tree test. Unfortunately, I cannot say that I know what that does or how (or why) Murali used that code in particular or how he came by it. So if I have to modify that, I'll need a *lot* of hand holding :P
Flags: needinfo?(mzehe)
Attachment #8855323 - Flags: review?(mzehe)
Comment on attachment 8855323 [details]
Sample test_contextmenu.html

You don't actually invoke the event sequence, or add the different invoker classes/functions to the gQueue that you define. So the context menu never gets opened, and the test will fail.

For future iterations of this, please ask :surkov for review, I'll be on PTO for the next two weeks.
Flags: needinfo?(mzehe)
Attachment #8855323 - Flags: review?(mzehe)
Ah... I had wondered about adding the gQueue code from events/text_contextmenu.html. Will work on it. Thanks.
Attached file Corrected test_contextmenu.html (obsolete) —
Made the corrections as suggested by Marco. However, I hadn't defined a gQueue as is done in events/test_contextmenu.html using the function doTests(). If that's necessary I'll add it.
Attachment #8855323 - Attachment is obsolete: true
Flags: needinfo?(surkov.alexander)
Attachment #8855877 - Flags: review?(surkov.alexander)
Comment on attachment 8855877 [details]
Corrected test_contextmenu.html

could you please attach a patch? https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_diff_and_patch_files.3F
Flags: needinfo?(surkov.alexander)
(In reply to Leni Kadali from comment #24)
> Created attachment 8857051 [details]
> Bug 702560 - add a11y mochitest for HTML 5 contextmenu
> 
> Here's the sample test_context.menu.html file.
> user: Leni Kadali <lenikmutungi@gmail.com>
> branch 'default'
> added accessible/tests/mochitest/tree/test_contextmenu.html
> 
> Review commit: https://reviewboard.mozilla.org/r/128952/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/128952/

would you please fix coding styling according to Mozilla coding style guide https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style:

* two spaces for indentation
* no spaces on empty lines
* no indent for {} of a function

Marco is right and you need to have gQueue stuff in the test, otherwise all functions you define like showContextMenu don't work at all.

Also please make sure your test works by running .mach mochitest path_to_your_test_file
Comment on attachment 8857051 [details]
Bug 702560 - add a11y mochitest for HTML 5 contextmenu

https://reviewboard.mozilla.org/r/128952/#review135754
Attachment #8857051 - Flags: review?(surkov.alexander)
Attachment #8855877 - Attachment is obsolete: true
Attachment #8855877 - Flags: review?(surkov.alexander)
Modified test_contextmenu.html
Comment on attachment 8861580 [details] [diff] [review]
add a11y mochitest for HTML 5 contextmenu

The above is my modified test_contextmenu.html. When I ran the ./mach mochitest accessible/tests/mochitest/tree/test_contextmenu.html, I got the following error message: 

Elapsed: 2.93s; From _tests: Kept 31820 existing; Added/updated 0; Removed 0 files and 0 directories.
The mochitest command could not find any mochitests under the following
test path(s):

accessible/tests/mochitest/tree/test_contextmenu.html

Please check spelling and make sure there are mochitests living there.

I don't know what I'm doing wrong. Pointers in the right direction would be helpful.
Flags: needinfo?(surkov.alexander)
Attachment #8861580 - Flags: review?(surkov.alexander)
You will need to add the new test to the a11y.ini file in that directory.
Flags: needinfo?(surkov.alexander)
Modified test_contextmenu.html

changed accessible/tests/mochitest/tree/a11y.ini
changed accessible/tests/mochitest/tree/test_contextmenu.html
Got the following error when I re-ran the test:

The following tests failed:
39 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Can't get DOM element for input
getNode@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:217:5
showContextMenu@chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html:34:20
doTests@chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html:123:19
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:672:12
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:174:9
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:672:12
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:164:5
focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:791:59
Buffered messages finished
SUITE-END | took 10s

How should I make sure that the DOM element for input is gotten?
Attachment #8861580 - Attachment is obsolete: true
Attachment #8861580 - Flags: review?(surkov.alexander)
Attachment #8861775 - Flags: review?(surkov.alexander)
Comment on attachment 8861775 [details] [diff] [review]
add a11y mochitest for HTML 5 contextmenu

Review of attachment 8861775 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/tree/test_contextmenu.html
@@ +23,2 @@
>    <script type="application/javascript">
>                  

is this a diff of changes from the previous patch? would you attach the whole patch? also please make sure there's no extra whitespaces in it.
Attachment #8861775 - Flags: review?(surkov.alexander)
(In reply to alexander :surkov from comment #31)
> Comment on attachment 8861775 [details] [diff] [review]
> add a11y mochitest for HTML 5 contextmenu
> 
> Review of attachment 8861775 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/tests/mochitest/tree/test_contextmenu.html
> @@ +23,2 @@
> >    <script type="application/javascript">
> >                  
> 
> is this a diff of changes from the previous patch? would you attach the
> whole patch? also please make sure there's no extra whitespaces in it.

Apologies, but I'm not particularly sure about that. I have definitely modified the file significantly since the last patch I submitted. I simply ran `hg diff` in the file's directory, then committed the patch and submitted it via `hg bzexport`. So to me I would think this is a diff of changes since the last patch, not the patch in its entirety. How do I submit the whole patch? Via MozReview?
Flags: needinfo?(surkov.alexander)
Modified test_contextmenu.html
***
Bug 702560 - add a11y mochitest for HTML 5 contextmenu
Modified test_contextmenu.html

changed accessible/tests/mochitest/tree/a11y.ini
changed accessible/tests/mochitest/tree/test_contextmenu.html
Got the following error when I re-ran the test:

The following tests failed:
39 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Can't get DOM element for input
getNode@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:217:5
showContextMenu@chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html:34:20
doTests@chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html:123:19
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:672:12
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:174:9
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:672:12
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:164:5
focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:791:59
Buffered messages finished
SUITE-END | took 10s

How should I make sure that the DOM element for input is gotten?

Removed the DOCTYPE declaration from the beginning of the file.
Attachment #8861775 - Attachment is obsolete: true
Comment on attachment 8862438 [details] [diff] [review]
add a11y mochitest for HTML 5 contextmenu

Have tried to provide the entire summary of changes. Hope this is enough.
Flags: needinfo?(surkov.alexander)
Attachment #8862438 - Flags: review?(surkov.alexander)
(In reply to Leni Kadali from comment #32)
> Apologies, but I'm not particularly sure about that. I have definitely
> modified the file significantly since the last patch I submitted. I simply
> ran `hg diff` in the file's directory, then committed the patch and
> submitted it via `hg bzexport`. So to me I would think this is a diff of
> changes since the last patch, not the patch in its entirety. How do I submit
> the whole patch? Via MozReview?

not sure, I use Mercurial Queue https://developer.mozilla.org/en-US/docs/Mozilla/Mercurial/Queuesm, you may find it useful too.

(In reply to Leni Kadali from comment #33)
> How should I make sure that the DOM element for input is gotten?

as far as I can tell, the test file doesn't have an element with 'input' id at all

(In reply to Leni Kadali from comment #34)
> Comment on attachment 8862438 [details] [diff] [review]
> add a11y mochitest for HTML 5 contextmenu
> 
> Have tried to provide the entire summary of changes. Hope this is enough.

still not there, it seems this is a diff between your last patch and the latest changes. Also there's a whole bunch of whitespaces there, which should be removed.
Removed whitespaces. This is pretty much the complete patch
with the exception of the <html><head> and <body> tags which have
remained unchanged.
Attachment #8862438 - Attachment is obsolete: true
Attachment #8862438 - Flags: review?(surkov.alexander)
Attachment #8863116 - Flags: review?(surkov.alexander)
Hello Marco. I hope you don't mind taking over the request for review from Alexander on this one as well.
Flags: needinfo?(mzehe)
Comment on attachment 8863116 [details] [diff] [review]
add a11y mochitest for HTML 5 contextmenu

This patch is hard to read, since you somehow changed all the indentations. It is difficult to see what's actually new, changed, and unchanged...

Could you provide a patch that retains the proper indentation of the file and therefore doesn't break all the history, and the diff is clearer? Thanks!
Flags: needinfo?(mzehe)
Attachment #8863116 - Flags: review?(surkov.alexander)
Added the file test_contextmenu.html
Worked on text indentation.
Added the test to a11y.ini
Output of the test is below.

user@localhost:~/src/mozilla-central$ ./mach mochitest accessible/tests/mochitest/tree/test_contextmenu.html
cat: backend.TestManifestBackend.in: No such file or directory
Build configuration changed. Regenerating backend.

######
### Now running mochitest-a11y.
######

Checking for orphan ssltunnel processes...
Checking for orphan xpcshell processes...
SUITE-START | Running 1 tests
mozprofile.addons WARNING | Could not install /home/user/src/mozilla-central/obj-x86_64-pc-linux-gnu/_tests/testing/mochitest/extensions/mozscreenshots: [Errno 2] No such file or directory: '/home/herabus/src/mozilla-central/obj-x86_64-pc-linux-gnu/_tests/testing/mochitest/extensions/mozscreenshots/install.rdf'
pk12util: PKCS12 IMPORT SUCCESSFUL
MochitestServer : launching [u'/home/user/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/bin/xpcshell', '-g', u'/home/herabus/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/bin', '-v', '170', '-f', u'/home/herabus/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/bin/components/httpd.js', '-e', "const _PROFILE_PATH = '/tmp/tmpsBnwHG.mozrunner'; const _SERVER_PORT = '8888'; const _SERVER_ADDR = '127.0.0.1'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = false;", '-f', '/home/herabus/src/mozilla-central/obj-x86_64-pc-linux-gnu/_tests/testing/mochitest/server.js']
runtests.py | Server pid: 30122
runtests.py | Websocket server pid: 30125
runtests.py | SSL tunnel pid: 30128
runtests.py | Running with e10s: False
runtests.py | Running tests: start.

Application command: /home/user/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/bin/firefox -marionette -foreground -profile /tmp/tmpsBnwHG.mozrunner
runtests.py | Application pid: 30150
TEST-INFO | started process GECKO(30150)
GECKO(30150) | 1496747387873    Marionette      INFO    Listening on port 2828
0 INFO SimpleTest START
1 INFO TEST-START | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html
2 INFO must wait for load
3 INFO must wait for load
GECKO(30150) | [30150] WARNING: g_type_add_interface_static: assertion 'g_type_parent (interface_type) == G_TYPE_INTERFACE' failed: 'glib warning', file /home/herabus/src/mozilla-central/toolkit/xre/nsSigHandlers.cpp, line 142
GECKO(30150) | (firefox:30150): GLib-GObject-CRITICAL **: g_type_add_interface_static: assertion 'g_type_parent (interface_type) == G_TYPE_INTERFACE' failed
GECKO(30150) | [30150] WARNING: g_type_add_interface_static: assertion 'g_type_parent (interface_type) == G_TYPE_INTERFACE' failed: 'glib warning', file /home/herabus/src/mozilla-central/toolkit/xre/nsSigHandlers.cpp, line 142
GECKO(30150) | (firefox:30150): GLib-GObject-CRITICAL **: g_type_add_interface_static: assertion 'g_type_parent (interface_type) == G_TYPE_INTERFACE' failed
GECKO(30150) | [30150] WARNING: g_type_add_interface_static: assertion 'g_type_parent (interface_type) == G_TYPE_INTERFACE' failed: 'glib warning', file /home/herabus/src/mozilla-central/toolkit/xre/nsSigHandlers.cpp, line 142
GECKO(30150) | (firefox:30150): GLib-GObject-CRITICAL **: g_type_add_interface_static: assertion 'g_type_parent (interface_type) == G_TYPE_INTERFACE' failed
4 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong value of property 'role' for ['div@id="container" node', address: [object HTMLDivElement], role: section, address: [xpconnect wrapped nsIAccessible]].
5 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong first child of ['div@id="container" node', address: [object HTMLDivElement], role: section, address: [xpconnect wrapped nsIAccessible]]
6 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong last child of ['div@id="container" node', address: [object HTMLDivElement], role: section, address: [xpconnect wrapped nsIAccessible]]
7 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong parent of ['div node', address: [object HTMLDivElement], role: section, address: [xpconnect wrapped nsIAccessible]]
8 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong index in parent of ['div node', address: [object HTMLDivElement], role: section, address: [xpconnect wrapped nsIAccessible]]
9 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong next sibling of ['div node', address: [object HTMLDivElement], role: section, address: [xpconnect wrapped nsIAccessible]]
10 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong previous sibling of ['div node', address: [object HTMLDivElement], role: section, address: [xpconnect wrapped nsIAccessible]]
11 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong value of property 'role' for ['div node', address: [object HTMLDivElement], role: section, address: [xpconnect wrapped nsIAccessible]].
12 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong first child of ['div node', address: [object HTMLDivElement], role: section, address: [xpconnect wrapped nsIAccessible]]
13 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong last child of ['div node', address: [object HTMLDivElement], role: section, address: [xpconnect wrapped nsIAccessible]]
14 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong parent of ['undefined node', address: [object Text], role: text leaf, name: 'Heaven', address: [xpconnect wrapped nsIAccessible]]
15 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong index in parent of ['undefined node', address: [object Text], role: text leaf, name: 'Heaven', address: [xpconnect wrapped nsIAccessible]]
16 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong next sibling of ['undefined node', address: [object Text], role: text leaf, name: 'Heaven', address: [xpconnect wrapped nsIAccessible]]
17 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong previous sibling of ['undefined node', address: [object Text], role: text leaf, name: 'Heaven', address: [xpconnect wrapped nsIAccessible]]
18 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong value of property 'role' for ['undefined node', address: [object Text], role: text leaf, name: 'Heaven', address: [xpconnect wrapped nsIAccessible]].
19 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong first child of ['undefined node', address: [object Text], role: text leaf, name: 'Heaven', address: [xpconnect wrapped nsIAccessible]]
20 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong last child of ['undefined node', address: [object Text], role: text leaf, name: 'Heaven', address: [xpconnect wrapped nsIAccessible]]
21 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong parent of ['undefined node', address: [object Text], role: text leaf, name: ' ', address: [xpconnect wrapped nsIAccessible]]
22 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong index in parent of ['undefined node', address: [object Text], role: text leaf, name: ' ', address: [xpconnect wrapped nsIAccessible]]
23 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong next sibling of ['undefined node', address: [object Text], role: text leaf, name: ' ', address: [xpconnect wrapped nsIAccessible]]
24 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong previous sibling of ['undefined node', address: [object Text], role: text leaf, name: ' ', address: [xpconnect wrapped nsIAccessible]]
25 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong value of property 'role' for ['undefined node', address: [object Text], role: text leaf, name: ' ', address: [xpconnect wrapped nsIAccessible]].
26 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong first child of ['undefined node', address: [object Text], role: text leaf, name: ' ', address: [xpconnect wrapped nsIAccessible]]
27 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Wrong last child of ['undefined node', address: [object Text], role: text leaf, name: ' ', address: [xpconnect wrapped nsIAccessible]]
GECKO(30150) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
GECKO(30150) | MEMORY STAT | vsize 1880MB | residentFast 249MB | heapAllocated 98MB
28 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Can't get DOM element for input
getNode@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:217:5
showContextMenu@chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html:23:18
doTests@chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html:113:15
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:676:12
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:174:9
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:676:12
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:164:5
focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
29 INFO TEST-OK | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | took 1202ms
30 INFO TEST-START | Shutdown
31 INFO Passed:  24
32 INFO Failed:  1
33 INFO Todo:    0
34 INFO Mode:    non-e10s
35 INFO Slowest: 1202ms - chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html
36 INFO SimpleTest FINISHED
37 INFO TEST-INFO | Ran 1 Loops
38 INFO SimpleTest FINISHED
GECKO(30150) | JavaScript error: resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/devtools-browser.js, line 861: TypeError: DebuggerServer.removeContentServerScript is not a function
TEST-INFO | Main app process: exit 0
runtests.py | Application ran for: 0:00:34.443794
zombiecheck | Reading PID log: /tmp/tmpCncBTFpidlog
==> process 30150 launched child process 30172
zombiecheck | Checking for orphan process with PID: 30172
Stopping web server
Stopping web socket server
Stopping ssltunnel
leakcheck | refcount logging is off, so leaks can't be detected!
runtests.py | Running tests: end.
The following tests failed:
39 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html | Can't get DOM element for input
getNode@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:217:5
showContextMenu@chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html:23:18
doTests@chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_contextmenu.html:113:15
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:676:12
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:174:9
setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:676:12
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:164:5
focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
Buffered messages finished
SUITE-END | took 41s

I hope this isn't too much.
Attachment #8863116 - Attachment is obsolete: true
Attachment #8874816 - Flags: review?(mzehe)
Comment on attachment 8874816 [details] [diff] [review]
add a11y mochitest for HTML 5 contextmenu

> [test_cssflexbox.html]
> [test_cssoverflow.html]
>+[test_contextmenu.html]

Nit: Move this last one above the other two to keep the files here in alphabetical order.

> >+function getContextMenuNode() 
> +{
> +  return getRootAccessible().DOMDocument.getElementById("contentAreaContextMenu");
Where does this ID come from? It isn't mentioned anywhere in the file below.

Also, you let the test suite finish twice, once right before the closing </head> tag as is usual, but once more further up in the file. That is not correct. Once the test is done, it's done. All invokers should run first, and the thing that calls simpleTest.Finish() should only be called once within a file.

Please correct these points and try your run again.
Attachment #8874816 - Flags: review?(mzehe)
Keywords: good-first-bug
Whiteboard: [good first bug]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: