Closed
Bug 702881
Opened 13 years ago
Closed 13 years ago
The document of nsIImportAddressBooks::GetSampleData is ambiguous
Categories
(MailNews Core :: Import, defect)
MailNews Core
Import
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 11.0
People
(Reporter: hiro, Assigned: hiro)
Details
Attachments
(1 file, 1 obsolete file)
|
1.60 KB,
patch
|
hiro
:
review+
|
Details | Diff | Splinter Review |
I actually misunderstood that the recordNumber of GetSampleData starts from 1.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #574791 -
Flags: review?(dbienvenu)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 574791 [details] [diff] [review] Additional info for params thx for the patch - can you remove the space after the '(' in the method line? You should probably also add an @returns line after the param to tell what the method returns, e.g., @returns a string of sample data for the desired record
Attachment #574791 -
Flags: review?(dbienvenu) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Addressing review comments. Carrying over review+.
Assignee: nobody → hiikezoe
Attachment #574791 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #576644 -
Flags: review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/comm-central/rev/52091c6aa7f9
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
You need to log in
before you can comment on or make changes to this bug.
Description
•