703398 - IndexedDB: SQLite files with unknown schema versions should not be deleted

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Our indexedDB code right now deletes sqlite databases if the schema version is higher than the in-tree schema. That's bad for testers since their data will be lost if they downgrade Firefox. Attached patch is for branches only since we need these before bug 702889 lands and upgrades the schema.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 575299 [details] [diff] [review]
Patch, v1

Review of attachment 575299 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that fixed.

::: dom/indexedDB/OpenDatabaseHelper.cpp
@@ +448,2 @@
>  
> +    if (schemaVersion != DB_SCHEMA_VERSION) {

If schemaVersion was 4 and we ran the upgrade code above, it'll still be 4 when you get here, right? Seems like you need to set it to 5 after calling UpgradeSchemaFrom4To5 above.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1.1

Fixed Jonas' review issue.

We'd really like to get this on aurora and beta since we want to make sure that downgrades of Firefox do not destroy indexedDB databases created with newer versions of Firefox. Firefox 11 will bump the schema, so we need 9 and 10 to handle this.

Comment 3

[LegNeato]

Comment on attachment 575324 [details] [diff] [review]
Patch, v1.1

[triage comment]
Approved for aurora and beta. Please land asap.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9c12817a0678
https://hg.mozilla.org/releases/mozilla-beta/rev/a4086b2b8132

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Did this ever land on mozilla-central?

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

This was only for branches iirc. We fixed on m-c in one of the other schema upgrades.