703633 - TreePanel.jsm uses a resource:/// url that ought to be resource://gre/

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Mike Hommey [:glandium]]

TreePanel.jsm includes resource:///modules/Services.jsm, which should really be resource://gre/modules/Services.jsm.

Comment 1

[Mike Hommey [:glandium]]

Attachment: TreePanel.jsm uses a resource:/// url that ought to be resource://gre/

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 575489 [details] [diff] [review]
TreePanel.jsm uses a resource:/// url that ought to be resource://gre/

thanks!

Comment 3

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/60ecd909a6c2

Comment 4

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/60ecd909a6c2

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 575489 [details] [diff] [review]
TreePanel.jsm uses a resource:/// url that ought to be resource://gre/

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: Inspect Element won't work
Fix Landed on Version: Firefox 11
Risk to taking this patch (and alternatives if risky): NONE
String or UUID changes made by this patch: NONE

Comment 6

[Mike Hommey [:glandium]]

(In reply to Martin Stránský from comment #5)
> User impact if declined: Inspect Element won't work

won't work in Firefox as a Xulrunner application.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 575489 [details] [diff] [review]
TreePanel.jsm uses a resource:/// url that ought to be resource://gre/

no risk, go ahead.

Comment 8

[Mike Hommey [:glandium]]

Realized too late that I pushed to the wrong branch:
http://hg.mozilla.org/releases/mozilla-esr10/rev/344e4df16abb
And landed again on the right one:
http://hg.mozilla.org/releases/mozilla-esr10/rev/454e3e33b5c3

Comment 9

[u279076]

Does this have or need a test case in-testsuite?

Comment 10

[Rob Campbell [:rc] (:robcee)]

no.