Closed
Bug 703645
Opened 13 years ago
Closed 13 years ago
rm SRC_TRACE
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: luke, Unassigned)
Details
Attachments
(1 file)
7.35 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Not because the tracer is going to be removed (bug 698201 doesn't touch SRC_TRACE), but because it seems to be unused save a single tracer-unrelated use for decompiling do loops which should just use SRC_WHILE. It's hard to be sure because of all the covert ways of getting to this stuff, but js/jit-tests seem to pass. Gary, do you suppose you could give this patch a little fuzzing?
Attachment #575504 -
Flags: review?(jwalden+bmo)
Comment 1•13 years ago
|
||
> js/jit-tests seem to pass. Gary, do you suppose you could give this patch a
> little fuzzing?
Yeah, this seems to hold up fine after a couple of minutes' fuzzing, it doesn't seem to immediately blow anything up... yet. (hopefully not ever)
Comment 2•13 years ago
|
||
Comment on attachment 575504 [details] [diff] [review] rm SRC_TRACE Review of attachment 575504 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/frontend/BytecodeEmitter.cpp @@ +5986,5 @@ > noteIndex = NewSrcNote(cx, bce, SRC_WHILE); > if (noteIndex < 0 || Emit1(cx, bce, JSOP_NOP) < 0) > return JS_FALSE; > > + noteIndex2 = NewSrcNote(cx, bce, SRC_WHILE); Why does this need two while notes in a row?
Reporter | ||
Comment 3•13 years ago
|
||
(In reply to Jeff Walden (remove +bmo to email) from comment #2) > Why does this need two while notes in a row? While loops need two offsets. Here is the use: http://hg.mozilla.org/mozilla-central/file/87da67ee3e59/js/src/jsopcode.cpp#l2417
Comment 4•13 years ago
|
||
Comment on attachment 575504 [details] [diff] [review] rm SRC_TRACE Review of attachment 575504 [details] [diff] [review]: ----------------------------------------------------------------- What a mess.
Attachment #575504 -
Flags: review?(jwalden+bmo) → review+
Reporter | ||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c3c5e4db3ad
Target Milestone: --- → mozilla11
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5c3c5e4db3ad
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•