Closed
Bug 703718
Opened 13 years ago
Closed 12 years ago
Unify dbg-server.js and dbg-server.jsm
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 13
People
(Reporter: past, Assigned: dcamp)
References
Details
Attachments
(1 file)
|
26.73 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
Currently the debugger server goes to lengths to shield itself from other compartments, by creating a sandbox and populating with the server code. We should just have dbg-server.jsm with the current contents of dbg-server.js.
|
Reporter | |
Comment 1•13 years ago
|
||
The rationale for this, as explained to me by dcamp, is that by the time we get to support the chrome debugging use case the JS engine will already have adequate protections in place that will render the sandbox approach redundant.
|
|
Reporter | |
Updated•12 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 2•12 years ago
|
||
This is mostly a simple move of dbg-server.js -> dbg-server.jsm. Diff is pretty dirty, sorry about that. Needed to add EXPORTED_SYMBOLS and loadSubScript to dbg-server.js, everything else is just dbg-server.js.
Assignee: nobody → dcamp
Attachment #596208 -
Flags: review?(past)
|
|
Reporter | |
Comment 3•12 years ago
|
||
Comment on attachment 596208 [details] [diff] [review] merge dbg-server.js/jsm Review of attachment 596208 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #596208 -
Flags: review?(past) → review+
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5acf0e26ddcd
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•