703938 - Move WebConsole style from toolkit to browser

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Comment 1

[Sonny Piers [:sonny]]

Attachment: WIP patch v0.1

Mihai,
* I deleted the "+" and "*" from jar.mn files because I think they are unneeded, what do you think?
* I deleted aero specific stuff because I don't think they are needed too. (aero herits from winstrip right?)
* What about files name?

Comment 2

[Sonny Piers [:sonny]]

Paul, I need tests on OSX/Windows, can you please run a try build with the patch?

Comment 3

[Sonny Piers [:sonny]]

Paul, try: -b do -e -p linux,macosx64,win32 -u mochitests -t none

Comment 4

[Paul Rouget [:paul]]

https://tbpl.mozilla.org/?tree=Try&rev=751b295adf53

Comment 5

[Mihai Sucan [:msucan]]

Comment on attachment 575749 [details] [diff] [review]
WIP patch v0.1

Review of attachment 575749 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good! As discussed on IRC, this patch needs an update for the winaero theme. The jar.mn file has two sections, one for aero. Please check and update the file as needed. Thank you!

Comment 6

[Sonny Piers [:sonny]]

Attachment: patch v0.2

Comment 7

[Sonny Piers [:sonny]]

paul, could you run a try build with the new patch?
try: -b do -p all -u mochitests -t none

Comment 8

[Sonny Piers [:sonny]]

Sorry I meant try: -b do -p linux,macosx64,win32 -u mochitests -t none

Comment 9

[Paul Rouget [:paul]]

> Thanks for your try submission (http://hg.mozilla.org/try/pushloghtml?changeset=96b7aabe658e). It's the best!
> Watch https://tbpl.mozilla.org/?tree=Try&rev=96b7aabe658e for your results to come in
> Builds and logs will be available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-96b7aabe658e
> This directory won't be created until the first builds are uploaded, so please be patient.

Comment 10

[Sonny Piers [:sonny]]

Attachment: wrong bug! sorry :-)

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 575976 [details] [diff] [review]
patch v0.2

>--- a/browser/themes/winstripe/jar.mn
>+++ b/browser/themes/winstripe/jar.mn

>         skin/classic/aero/browser/tabview/tabview.png                (tabview/tabview.png)
>         skin/classic/aero/browser/tabview/tabview-inverted.png       (tabview/tabview-inverted.png)
>         skin/classic/aero/browser/tabview/tabview.css                (tabview/tabview.css)
>         skin/classic/aero/browser/devtools/arrows.png                (devtools/arrows.png)
>         skin/classic/aero/browser/devtools/goto-mdn.png              (devtools/goto-mdn.png)
>         skin/classic/aero/browser/devtools/csshtmltree.css           (devtools/csshtmltree.css)
>         skin/classic/aero/browser/devtools/gcli.css                  (devtools/gcli.css)
>         skin/classic/aero/browser/devtools/toolbarbutton-close.png   (devtools/toolbarbutton-close.png)
>+        skin/classic/browser/devtools/webconsole.css                  (devtools/webconsole.css)
>+        skin/classic/browser/devtools/webconsole_networkpanel.css     (devtools/webconsole_networkpanel.css)
>+        skin/classic/browser/devtools/webconsole.png                  (devtools/webconsole.png)

This needs to be skin/classic/aero/browser/

Comment 12

[Sonny Piers [:sonny]]

Attachment: patch v1

Comment 13

[Sonny Piers [:sonny]]

Dao, of course, sorry.

Comment 14

[Sonny Piers [:sonny]]

Attachment: patch v1.1

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 576690 [details] [diff] [review]
patch v1.1

long overdue. thanks :)

Comment 16

[Mihai Sucan [:msucan]]

Comment on attachment 576690 [details] [diff] [review]
patch v1.1

Review of attachment 576690 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. Sonny, thank you very much for your contribution!

(apologies for the delay! the email with the review request got lost somehow...)

Comment 17

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 576690 [details] [diff] [review]
patch v1.1

readded the preprocessing directive to pinstripe's jar.mn file. Styles weren't applying there.

Comment 18

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/ce0a05f13572

Comment 19

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/ce0a05f13572