Closed Bug 704520 Opened 13 years ago Closed 13 years ago

Flash content does not have a placeholder if on Android 3.x

Categories

(Firefox for Android Graveyard :: General, defect, P1)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect

Tracking

(firefox11 fixed, fennec11+)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: kbrosnan, Assigned: blassey)

References

Details

Attachments

(2 files, 1 obsolete file)

Screenshot
585.27 KB, image/png
Details
patch
809 bytes, patch
snorp
: review+
Details | Diff | Splinter Review 
On 2.1, 3.x and 4.0 we are not creating the placeholder for flash content on a page.
Priority: -- → P1
Margaret can you reproduce this?
Assignee: nobody → margaret.leibovic
I see the missing plugin UI. Tested on a Galaxy S (2.3) and Galaxy Nexus (4).
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
I still see this on today's nightly using my Transformer.
Status: REOPENED → NEW
Summary: Flash content does not have a placeholder if on a unsupported device or flash is not installed → Flash content does not have a placeholder if on Android 3.x
Attached image Screenshot — 
Since this is Honeycomb only I doubt this is a P1.
Attached patch patch (obsolete) — — Splinter Review 
So, technically, this is correct. The reason there's no placeholder is because there is a flash plugin on the system an we're loading and initializing it. But, because its honeycomb, we can't draw anything. This patch will prevent us from finding any plugins on honeycomb (and ICS).

Madhava, we might want to have different text in the placeholder for these platforms. Something to the effect of "Plugins are not supported on this platform" rather than "A plugin is needed to display this content"
Assignee: margaret.leibovic → blassey.bugs
Attached patch patch — — Splinter Review 
damnit, wrong patch
Attachment #580574 - Attachment is obsolete: true
Attachment #580575 - Flags: review?(snorp)
Attachment #580575 - Flags: review?(snorp) → review+
pushed https://hg.mozilla.org/mozilla-central/rev/202f4ccbbda1
Status: NEW → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Whiteboard: [QA+]
tracking-fennec: --- → 11+
(In reply to Brad Lassey [:blassey] from comment #6)
> Madhava, we might want to have different text in the placeholder for these
> platforms. Something to the effect of "Plugins are not supported on this
> platform" rather than "A plugin is needed to display this content"

I filed bug 725286 for this.
Verified on:
Nightly Fennec 13.0a1 (2012-03-04)
Devices: HTC Desire Z (Android 2.3.3), Galaxy Nexus (Android 4.0), Acer A500(Android 3.2)
Status: RESOLVED → VERIFIED
Whiteboard: [QA+]
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: