704534 - Automatic install doesn't start after purchase with the HTML5 implementation

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Make sure you DON'T have the OWA extension installed.
2. Load https://apps-preview-dev.allizom.org/en-US/apps/app/marble-run/?src=cb-dl-home
3. Purchase the app

expected behavior:
After purchase, automatic install starts with confirmation box showing up.

actual behavior:
After purchase, automatic install doesn't start.

Comment 2

[Andy McKay]

There's a couple of issues locally that this exposes:

1) the apps.install method fails and is dropping us into https://github.com/mozilla/zamboni/blob/master/media/js/zamboni/apps.js#L86, showError. This is another modal and there's something in the timing that is wrong.

2) having the thank you modal removed and replaced with an error modal is horrid and not helpful to the user.

3) why is apps.js install failing in the first place.

I need to solve 3) and I think 2) needs to be handled in a different way. 1) might just be a bug in modals/timing/callbacks/js/life in general.

Comment 3

[Andy McKay]

Example (when my data is bit messed up) http://screencast.com/t/zPQcMdia0

Comment 4

[Andy McKay]

I'm getting: uncaught exception: Channel.build() called without a valid window argument

This looks related: https://github.com/mozilla/browserid/issues/75 thanks @cvan.

Comment 5

[Andy McKay]

This is a workaround. Lots of  credit to @cvan, awesome help thank you.

https://github.com/mozilla/zamboni/commit/cc744d

Will file a bug for the modals, but that's low priority.