704820 - Simplify nsContentUtils::ReportToConsole

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

Most callers do not set params, paramsLength, URI, source, lineNumber.
columnNumber is not used at all!
Most callers do not set non-zero windowID.
So I propose the follwing changes:
- Move flags, category and doc params onto other rarer used params and make the rest params optional.
- Remove the windowID version method.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

Comment 2

[Masatoshi Kimura [:emk]]

Apply this on top of bug 701787's patch.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Looks like the only caller that passes a raw window ID is the nsIDOMWindowInternal one, so it's probably fine to remove that variant.

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: patch

Updated to tip

Comment 5

[Dão Gottwald [:dao]]

Please mark this for check-in once the dependencies are cleared.

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Simplify nsContentUtils::ReportToConsole. r=smaug

Updated to tip

Comment 7

[Masatoshi Kimura [:emk]]

The dependent bug has been fixed.

Comment 8

[Ed Morley [:emorley]]

In my queue with a few other checkin-neededs that are being sent to try first and then onto inbound :-)
https://tbpl.mozilla.org/?tree=Try&rev=fd440327d5e4

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8659eb419fb

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e8659eb419fb