Closed Bug 704837 Opened 13 years ago Closed 13 years ago

Regression in bidi reordering

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla10
Tracking Flags:
Tracking Status
firefox9 --- unaffected
firefox10 + verified

People

(Reporter: smontagu, Assigned: smontagu)

References

(
URL
)

Details

(Keywords: regression, rtl, verified-beta, Whiteboard: [qa+][qa!:10])

Attachments

(3 files)

Testcase minimized from Facebook
270 bytes, text/html
Details
Patch
1.91 KB, patch
roc
: review+
asa
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Reftest
1.81 KB, patch
roc
: review+
Details | Diff | Splinter Review 
The second line of this testcase is displayed backwards.
Attached patch Patch — — Splinter Review 

        Attachment #576526 -
        Flags: review?(roc)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Reftest
        — 
          — Splinter Review
      

    


  

        Attachment #576527 -
        Flags: review?(roc)

    
    

    
  
What caused this regression? Seems like we should get this fixed on Aurora and maybe Beta?

    
    

    
  
It's regression from bug 698706, so it needs to be fixed on trunk and Aurora.
Blocks: 698706

          status-firefox10:
          --- → affected

          status-firefox9:
          --- → unaffected

          tracking-firefox10:
          --- → ?
Keywords: regression

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1a3138631654
https://hg.mozilla.org/mozilla-central/rev/fdd08d684e38
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 576526 [details] [diff] [review]
Patch

Asking approval-aurora after trunk baking. The patch is very low-risk and fixes a regression in aurora from bug 698706.

        Attachment #576526 -
        Flags: approval-mozilla-aurora?

    
  

        Attachment #576526 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Comment on attachment 576526 [details] [diff] [review]
Patch

[Triage Comment]
Looks like a good regression fix. Let's take this on Aurora.

    
  
Whiteboard: [qa+]

    
    

    
  
Could you please provide me some additional info in order to verify this? I can't figure out if https://www.facebook.com/Clalit/posts/10150943051525693 is displayed properly or not.

    
    

    
  
Search for "כרום" in that page and verify that both times it appears it is displayed as כרום, not םורכ

    
    

    
  
Based on comment 12, this is verified fixed on Firefox 10 Beta2:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20100101 Firefox/10.0

          status-firefox10:
          fixed → verified
Keywords: verified-beta
Whiteboard: [qa+] → [qa+][qa!:10]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: