704841 - Use implicit_jscontext for Components.utils getters

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

There's a
  // FIXME/bug 671453: work around broken [implicit_jscontext]
comment, but bug 671453 has been fixed. Let's use it.

Comment 1

[Josh Matthews [:jdm]]

Relevant code:
http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/idl/xpccomponents.idl#321
http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCComponents.cpp#4053

All of the attributes in nsIXPCComponents_Utils should have the implicit_jscontext attribute added. The getters and setters generated by the macros in the C++ file will then get a JSContext* parameter added to them, which should be used instead of the GetJSContext function they currently call.

Comment 2

[Reuben Morais [:reuben]]

Attachment: Patch

Comment 3

[Josh Matthews [:jdm]]

Comment on attachment 578254 [details] [diff] [review]
Patch

Nice!

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 578254 [details] [diff] [review]
Patch

Looks good! r=bholley

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/8d316e7fd4b0

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8d316e7fd4b0