705009 - DeviceMotion accelerationIncludingGravity values are in units of "G"s

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The current spec says they should be in units of m/s^2, but they're currently reported as fractional multiples of 1G.  I'm not sure what happens on other platforms.  We should do what the spec says.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Report DeviceMotion values in units of m/s^2, not Gs, per current spec

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 576649 [details] [diff] [review]
Report DeviceMotion values in units of m/s^2, not Gs, per current spec

Review of attachment 576649 [details] [diff] [review]:
-----------------------------------------------------------------

this is fine, thanks!  could you also make sure that the absolute property of DeviceOrientationEvent is |true|?

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

It's set to true unconditionally at http://mxr.mozilla.org/mozilla-central/source/dom/system/nsDeviceMotion.cpp#275, the only site I found.  I don't know whether the data is absolute per spec or not.

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/601d585e1e35

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/601d585e1e35