705047 - mochitest-2 (or mochitest-3, depending on the branch) *and* mochitest-chrome failures on Mac OS X 10.7 (Lion) and 10.8 (Mountain Lion) related to leaving crash dumps behind

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There are now unit tests running on Mac OS X 10.7, some of which are hidden.

I'm filing this bug on all the "left crash dumps behind" related failures, which are a major chunk of the failures needed to get the test suites green.

The opt mochitest-2 runs are failing with:

5177 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/plugins/test/test_crashing.html | This test did not leave any crash dumps behind, but we were expecting some!
5178 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/plugins/test/test_crashing.html | This test left crash dumps behind, but we weren't expecting it to!

The debug mochitest-2 runs are failing with:

TEST-UNEXPECTED-FAIL | /tests/dom/plugins/test/test_crashing.html | application timed out after 330 seconds with no output
PROCESS-CRASH | /tests/dom/plugins/test/test_crashing.html | application crashed (minidump found)

The opt reftest runs are failing (BUT, DISTURBINGLY, THIS DOESN'T AFFECT THE NUMBER OF REFTEST FAILURES SHOWN AND MAY NOT AFFECT THE ORANGENESS STATE) with:

REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/dom/plugins/test/reftest/pluginproblemui-direction-1.html | This test left crash dumps behind, but we weren't expecting it to!
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/dom/plugins/test/reftest/pluginproblemui-direction-1-ref.html | This test left crash dumps behind, but we weren't expecting it to!
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/dom/plugins/test/reftest/pluginproblemui-direction-2.html | This test left crash dumps behind, but we weren't expecting it to!
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/dom/plugins/test/reftest/pluginproblemui-direction-2-ref.html | This test left crash dumps behind, but we weren't expecting it to!

The debug reftest runs are failing with:

PROCESS-CRASH | file:///Users/cltbld/talos-slave/test/build/reftest/tests/dom/plugins/test/reftest/pluginproblemui-direction-1.html | application crashed (minidump found)
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | missing output line for total leaks!


For logs, see: https://tbpl.mozilla.org/?noignore=1

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also:

opt mochitest-chrome:

4317 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/plugins/test/test_crash_notify.xul | got a non-empty crash id - didn't expect , but got it
4318 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/plugins/test/test_crash_notify.xul | minidump exists
4319 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/plugins/test/test_crash_notify.xul | extra file exists
4320 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/plugins/test/test_crash_notify.xul | [SimpleTest/SimpleTest.js, window.onerror] - An error occurred: uncaught exception: [Exception... "Component returned failure code: 0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) [nsIFile.remove]" nsresult: "0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST)" location: "JS frame :: chrome://mochitests/content/chrome/dom/plugins/test/test_crash_notify.xul :: <TOP_LEVEL> :: line 44" data: no] at :0
4321 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/plugins/test/test_crash_notify.xul | This test left crash dumps behind, but we weren't expecting it to!
4339 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/plugins/test/test_crash_submit.xul | This test left crash dumps behind, but we weren't expecting it to!

debug mochitest-chrome:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/plugins/test/test_crash_notify.xul | application timed out after 330 seconds with no output
PROCESS-CRASH | chrome://mochitests/content/chrome/dom/plugins/test/test_crash_notify.xul | application crashed (minidump found)

Comment 2

[Cameron McCormack (:heycam)]

The reason for the reftest failures is going to be different from the mochitest failures, so I filed a separate bug 708165 for the reftest half.

Comment 3

[Cameron McCormack (:heycam)]

One common thing contributing to both the mochitest and reftest plugin crash test failures is that Breakpad is asserting and aborting on 10.7.  This might be bug 693451 but I am not sure.

Comment 4

[Phil Ringnalda (:philor)]

Attachment: disable our way to victory

https://tbpl.mozilla.org/?tree=Try&rev=b5d0d2743d24&noignore=1

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e27c8eb2bca

Comment 6

[Ed Morley [:emorley]]

> disable our way to victory

https://hg.mozilla.org/mozilla-central/rev/5e27c8eb2bca

Comment 7

[Phil Ringnalda (:philor)]

Attachment: 10.8

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2719a1e92ba4

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/500dac3a151b because I'm dumb.

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2719a1e92ba4
https://hg.mozilla.org/mozilla-central/rev/500dac3a151b

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/519253e9b054
https://hg.mozilla.org/releases/mozilla-beta/rev/b3fd58dc4f7c

Comment 12

[(not currently active) Ted Mielczarek]

Attachment: re-enable OOP crashreporter tests on mac

This is blocked by a bug I haven't filed yet on updating our Breakpad snapshot to latest-SVN, but all the tests seem to pass locally on my 10.7 machine. I'll run it through try when I get all the other platforms sorted out.

Comment 13

[(not currently active) Ted Mielczarek]

This also re-enables the test from bug 757722

Comment 14

[(not currently active) Ted Mielczarek]

These all looked fine on my Try push:
https://tbpl.mozilla.org/?tree=Try&rev=32a1f6c22385

(the Linux and Windows bustage was other issues)

Comment 15

[Phil Ringnalda (:philor)]

Comment on attachment 661782 [details] [diff] [review]
re-enable OOP crashreporter tests on mac

lgtm

Comment 16

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/776f7325952b

Comment 17

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/c1e97e2838a7 along with bug 791775

Comment 18

[(not currently active) Ted Mielczarek]

re-landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42b4cad82f1a

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/42b4cad82f1a