705133 - move all linux CC and CXX lines to a central mozconfig snippet

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: move all linux CC and CXX lines to a central mozconfig snippet

https://tbpl.mozilla.org/?tree=Try&rev=ca978ba45b1f

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: move all linux CC and CXX lines to a central mozconfig snippet

https://tbpl.mozilla.org/?tree=Try&rev=53d28e4b032b

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 576763 [details] [diff] [review]
move all linux CC and CXX lines to a central mozconfig snippet

Review of attachment 576763 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/unix/mozconfig.linux
@@ +1,2 @@
> +. $topsrcdir/build/unix/mozconfig.linux
> +

I think you want actual contents here like

CC=/tools/gcc-4.5-0moz2/bin/gc
CXX=/tools/gcc-4.5-0moz2/bin/g++

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: move all linux CC and CXX lines to a central mozconfig snippet

I guess I ran sed before and after adding the file :-(

Fixed now.

Comment 5

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Try&rev=348b9f1e7218

Comment 6

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1472d3eb887

Comment 7

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/b1472d3eb887