70532 - Import Settings and "Leave Messages on Server" is not selected

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[Ninoschka Baca]

Build 2001-02-26-09: NT4

Overview: Using Eudora, Outlook Express and Outlook I configured a POP account
and specifically selected the option to "Leave Messages on the Server". After
importing into Netscape6 I noticed that this setting is Not saved in the Account
Setting's Server panel.

Expected Results: I would expect the "Leave Messages on Server" option selected
since this setting was previously selected in Eudora, Outlook Express and Outlook.

Comment 1

[Ninoschka Baca]

Marking nsbeta1 because a user may be surprised if they expect there messages to
remain on the server.

Comment 2

[scottputterman]

marking nsbeta1+ and moving to mozilla0.9

Comment 3

[scottputterman]

reassigning to chuang.

Comment 4

[chuang]

reassign to Tony.

Comment 5

[scottputterman]

reassigning back to chuang. It was a miscommunication problem on my part.

Comment 6

[scottputterman]

moving to mozilla0.9.1

Comment 7

[chuang]

I have the fix for Eudora on Win32.  However, there's an issue on Mac.  The
resource IDs we used to get the pop server name, user name, etc is different
between Eudora 5.0 and Eudora 5.1.   Are we going to support just 5.1?   I'm
fixing it based on 5.1.

Comment 8

[scottputterman]

There's been a private email conversation on this so I'll add what was said in
it.  It sounds like we will support all versions of Windows Eudora.  My feeling
is that for the Mac, starting off with 5.1 is fine and we should open another
bug for supporting previous bersion.

Comment 9

[chuang]

Attachment: Patch for the fix

Comment 10

[chuang]

The fix is for Eudora on Mac and Win32,  Outlook and Outlook Express on Win32.

Comment 11

[Jean-Francois Ducarroz]

in EudoraMac, when you do stuff like that:
+
	GetIndString( pStr[0], resId /* 1000 */, 4);//	smtp server

can use use the constant (k...) instead of a numerical for the string index?

Comment 12

[Jean-Francois Ducarroz]

MacOS API use pascal string therfore the first byte in the string is the length
of the string and not the first characters. Also looks like to derefence the
string one level to much (*pStrs[n])[n]. Therefore the following line should not
works:
+        pop3Server->SetLeaveMessagesOnServer(*pStrs[kLeaveOnServerStr])[0] ==
'Y' ? PR_TRUE : PR_FALSE);

instead use:
+        pop3Server->SetLeaveMessagesOnServer(pStrs[kLeaveOnServerStr][1] == 'Y'
? PR_TRUE : PR_FALSE);

PS: I haven't tested it :-)

Comment 13

[chuang]

Attachment: A new patch with minor change on nsOESettings.cpp

Comment 14

[chuang]

I'll change those numbers into constants.  The pStrs is a nsCString array and
has been assigned value from the Mac pascal string (code is in
nsEudoraMac::ImportSettings() and nsEudoraMac::GetSettingsFromResource()). 
"*pStrs[kLeaveOnServerStr])[0]"  has been tested and worked on Mac.

Comment 15

[chuang]

Attachment: New patch with constants

Comment 16

[chuang]

Got r=ducarroz.

Comment 17

[Scott MacGregor]

sr=mscott....looks good to me.

Comment 18

[scottputterman]

It looks like this got checked in so I'm marking fixed.  Please reopen if I'm
wrong about this.

Comment 19

[Ninoschka Baca]

Build 2001-05-16-04: WinMe/ Eudora 5.1, Outlook Express 5, Outlook 98: Fixed.

Question: I have configured Eudora on the Mac but when I import the settings
what file do I choose?

Comment 20

[chuang]

If I remember correctly,  you choose "Eudora Setting".  I forgot where is this 
file.  If you can't find it.  I'll find it tomorrow when I'm in the office.

Comment 21

[Ninoschka Baca]

Build 2001-05-17-08: Mac 9.04
Verified Fixed, but there is a problem with the UI in Account Settings.

After choosing the "Eudora Settings" file the folder pane displays an account 
called "Eudora Settings" with preset folders (Inbox, Drafts, Templates, Sent, 
Trash). After selecting the Inbox, I can get messages. The problem is in Account 
Settings because it does not display a "Server" and "Copies and Folders" panel. 
The settings appear more like "Local Folders" so it's difficult to confirm 
whether the "Leave Messages on Server" option is selected since the UI is not 
there.

The prefs.js file shows Leave Messages on Server pref is set to true 
{user_pref("mail.server.server1.leave_on_server", true);}. If I configure a new 
profile for the same mail account using the Account Wizard (qatest20), then the 
same messages are retrieved so it appears that the pref is working. 

For the above reasons I am verifying this bug. I will create a new bug for the 
UI problem especially since it is only a Mac problem.

Comment 22

[Ninoschka Baca]

Note: Bug# 82019 covers the UI problem on the Mac.