705356 - Remove JSOPTION_JIT and JSOPTION_PROFILING

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

JSOPTION_JIT is unused now that TM has been removed. References to it should be removed.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Patch

dvander, can you review this?

Also, I'm wondering if some of these removals should have JSOPTION_METHODJIT and/or JSOPTION_TYPE_INFERENCE set instead of outright removal. Comments?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

JSOPTION_PROFILING should probably go too, now that I think about it.

Comment 3

[Mozilla RelEng Bot]

Try run for c0b6fe6eb324 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c0b6fe6eb324
Results (out of 13 total builds):
    exception: 7
    failure: 6
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-c0b6fe6eb324

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: Remove JSOPTION_JIT and JSOPTION_PROFILING

This patch also removes the profiling prefs. Try results incoming.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

David, this apparently blew up xpcshell tests. I can't figure out why, though.
https://tbpl.mozilla.org/?tree=Try&rev=24e506407c7f

Comment 6

[Mozilla RelEng Bot]

Try run for 24e506407c7f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=24e506407c7f
Results (out of 190 total builds):
    exception: 1
    success: 142
    warnings: 41
    failure: 6
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-24e506407c7f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Of course! It was probably dying because xpcshell was being invoked with -j still. Pretty funny since I had posted a patch to bug 604216 just prior to filing this one to change that to -m -n. Trying this push again with both patches this time.

Comment 8

[Mozilla RelEng Bot]

Try run for d7cd75718272 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=d7cd75718272
Results (out of 189 total builds):
    exception: 1
    success: 164
    warnings: 19
    failure: 5
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-d7cd75718272

Comment 9

[Ryan VanderMeulen [:RyanVM]]

xpcshell tests are all green now!

Comment 10

[Daniel Holbert [:dholbert]]

(note that bug 604216 landed on m-i earlier today)

Landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d984d11bffea

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/d984d11bffea