705660 - OpenSearch tab looks weird with some Personas

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: A screenshot of the weirdness

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a2) Gecko/20111125 Thunderbird/10.0a2

I've got this Persona enabled:  http://www.getpersonas.com/en-US/persona/23285

And the sidebar in my OpenSearch tab looks kinda funky.  See attached.

Comment 1

[Mark Banner (:standard8)]

Can anyone help with a quick fix for this? We're shipping opensearch in 10, so I'd like this to look good with personas.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

Talking with Richard on irc, this should work. Basically force the background color of the .navbar to -moz-dialog all the time.

I've also pushed this to try server to just get builds out, although I'd like to get it in the beta that I'm planning on starting tomorrow morning pst:

http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=8d44b7278d69

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 589000 [details] [diff] [review]
The fix

I think, ideally, I'ld like it to be the same colour as the folder pane, but this seems like enough of an improvement to get the ui-r=me.

And the code seems great, too.  r=me.  :)

Thanks,
Blake.

Comment 4

[Mark Banner (:standard8)]

Checked into trunk: http://hg.mozilla.org/comm-central/rev/e9fc23fc9027

Comment 5

[Mark Banner (:standard8)]

Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/e039f47e9b73
http://hg.mozilla.org/releases/comm-beta/rev/d2b206863e7a