Closed
Bug 705731
Opened 13 years ago
Closed 13 years ago
Create InspectorUI.notifications.DESTROYED notification
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 11
People
(Reporter: rcampbell, Assigned: rcampbell)
References
Details
Attachments
(1 file)
|
5.29 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
Tilt needs to know when the Inspector has been explicitly closed instead of the more generic InspectorUI.notifications.CLOSED event which fires whenever it is closed for whatever reason. The notification should also include the DOM Window ID as data.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•13 years ago
|
||
Adds a DESTROYED notification fired when the inspector is completely removed.
Attachment #578367 -
Flags: review?(paul)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 578367 [details] [diff] [review] destroy notification Review of attachment 578367 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #578367 -
Flags: review?(paul) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/cc69fe7c9f26
Whiteboard: [landed-in-fx-team]
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cc69fe7c9f26
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [landed-in-fx-team]
Target Milestone: --- → Firefox 11
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•