705967 - reftest assumes we are loaded in a window and have direct access to a document

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: use refWindow to access window and document (1.0)

if we are to load reftests outside of a content or xul window (say as a javascript module or via a bootstrap extension), we will not have access to window.* or document.*.

This patch resolves this for reftest.js by adding a refWindow which we use to references everything.  

here is a link to a try server run with this patch:
https://tbpl.mozilla.org/?tree=Try&rev=5338880f9ddf

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 577454 [details] [diff] [review]
use refWindow to access window and document (1.0)

># HG changeset patch
># Parent c3b13c7ff1cbf58d8a4a9c4add5f167eba72e512
>try: -b o -p all -u reftest,reftest-ipc,reftest-no-accel,crashtest,crashtest-ipc,jsreftest -t none

In the future, please use useful commit messages when posting patches for review.

>+var refWindow = null;

How about gContainingWindow instead of refWindow?

r=dbaron with that

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: use gContainingWindow to access window and document (1.1)

updated patch to variable name changed as per review.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

landed on m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3d5b255e109

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/e3d5b255e109