706060 - Upload custom icon does not work in IE9, Safari

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Cristian Boldan]

Attachment: upload icon Safari

Steps to reproduce:
1. Login to AMO apps page https://apps-preview-dev.allizom.org/en-US/apps/
2. Submit a new app to get to step 4
3. Upload a custom icon

Expected Results:
Preview of the uploaded image is shown

Actual Results:
Preview is not showing and custom icon is not uploaded. The default icon is not changing on IE9 and on Safari a question mark is shown in the preview areas

Notes/Issues:
Verified on IE9 and Safari (Win7 and MacOSX)
Attaching screenshot for this issue on Safari
Screencast for this issue on IE9 http://screencast.com/t/Lqs7d7dfGN

Comment 1

[Davor Spasovski [:spasovski]]

Done: https://github.com/mozilla/zamboni/commit/88d22270

The correct behavior should now be that the icon preview area disappears for browsers that don't support formdata like safari and ie9.

Comment 2

[Cristian Boldan]

Issue still reproducing in IE9 and Safari.
Screencast for IE9 http://screencast.com/t/vsxeIShb
Screencast for Safari http://screencast.com/t/Z0QEwwfQPbQ

Comment 3

[Davor Spasovski [:spasovski]]

Seems an old JS asset was used which means the fix didn't make it to staging...should be alright now.

Comment 4

[Cristian Boldan]

Issue still reproducing in IE9.
Screencast for IE9 http://screencast.com/t/vsxeIShb
Action behaves as expected on Safari, with no issues  http://screencast.com/t/GPWWViE3

Comment 5

[Davor Spasovski [:spasovski]]

IE9 should also be covered now:

https://github.com/mozilla/zamboni/commit/8019e52b

Comment 6

[Cristian Boldan]

Issue still reproducing in IE9.
Screencast fot IE9 http://screencast.com/t/BFd6BqzGj
Icon preview area dissapears, but after the "Save Changes" button is clicked, the image for the icon is not uploaded.

Comment 7

[Davor Spasovski [:spasovski]]

710303 covers the image submissions not working in IE9, this is a more involved fix that will have to be implemented.

Comment 8

[Cristian Boldan]

Fixed by new designs.
Closing bug.