706113 - Remove null checks after constructors in VideoDocument.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

> mozilla::dom::VideoDocument* doc = new mozilla::dom::VideoDocument();
> NS_ENSURE_TRUE(doc, NS_ERROR_OUT_OF_MEMORY);

These checks are unnecessary since we are not using |new (std::nothrow)|.

http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/VideoDocument.cpp#161

http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/VideoDocument.cpp#87

Comment 1

[Tobias (:Tobbi) Markus]

Attachment: patch

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 578019 [details] [diff] [review]
patch

Looks good to me, but I can't review this. I've forwarded the review to Olli.

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62df7e3891cd

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/62df7e3891cd