Closed
Bug 706297
Opened 13 years ago
Closed 13 years ago
Unnecessary glFinish before glReadPixels in LayerManagerOGL
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
Attachments
(1 file)
|
1014 bytes,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
In LayerManagerOGL::CopyToTarget(), we use glReadPixels to download the data from the GPU. glReadPixels implies glFinish, which means the preceeding glFinish here is redundant.
|
Assignee | |
Comment 1•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=a49982bcecf6
|
||
Comment 2•13 years ago
|
||
Everytime a useless glFinish call goes away, my personal happiness gets incremented.
|
|
Assignee | |
Comment 3•13 years ago
|
||
Assignee: nobody → jgilbert
Attachment #578131 -
Flags: review?(bjacob)
|
|
||
Updated•13 years ago
|
Attachment #578131 -
Flags: review?(bjacob) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Derp, almost forgot the inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/e0dd8b223460
Target Milestone: --- → mozilla11
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e0dd8b223460
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•