706663 - Empty Favicons on about:home look like checkboxes

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (11/30)

Currently the Favicon for empty entries in the "Favorite Sites" area look like tiny checkboxes; they're somewhat indistinguishable.

Ian/Madhava, what say you?

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

11-30 16:25:51.366: D/GeckoFavicons(2773): The provided URL is not valid: java.net.MalformedURLException: Unknown protocol: about

related to bug 705732?

Comment 2

[Lucas Rocha (:lucasr)]

(In reply to Naoki Hirata :nhirata from comment #1)
> 11-30 16:25:51.366: D/GeckoFavicons(2773): The provided URL is not valid:
> java.net.MalformedURLException: Unknown protocol: about
> 
> related to bug 705732?

Naoki, nope. Bug 705732 is more of a performance improvement.

Comment 3

[Lucas Rocha (:lucasr)]

Ian/Madhava, we should be prepared for the cases where the website screenshot is not available for some reason. We need a funny placeholder image for those cases.

Comment 4

[Ian Barlow (:ibarlow)]

Thanks Lucas, I will take a look.

FYI on a related note, I filed a bug yesterday about making website thumbnail placeholders too, for when screenshots aren't available (bug 706636)

Comment 5

[Madhava Enros [:madhava]]

We have a placeholder thumbnail image and we're using it now, aren't we? We're no longer scaling up favicons here.

Patryk's also created a bug to use higher res favicons on our internal pages and for external pages with no favicon.

Given that, I'm moving this to "fixed".

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Madhava Enros [:madhava] from comment #5)
> We have a placeholder thumbnail image and we're using it now, aren't we?
> We're no longer scaling up favicons here.
> 
> Patryk's also created a bug to use higher res favicons on our internal pages
> and for external pages with no favicon.
> 
> Given that, I'm moving this to "fixed".

madhava, is this fixed to your satisfaction in aurora as well? if so please set status-firefox-11 to fixed