706682 - don't access bgra[4]

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: fix it

https://tbpl.mozilla.org/?tree=Try&rev=134e95588dc2

Comment 2

[Josh Aas]

Comment on attachment 578121 [details] [diff] [review]
fix it

Review of attachment 578121 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/test/testplugin/nptest_utils.cpp
@@ +93,5 @@
>  parseHexColor(const char* color, int len)
>  {
>    PRUint8 bgra[4] = { 0, 0, 0, 0xFF };
>    int i = 0;
> +  assert(len == 9);

The description for this function strongly implies that the length does not have to be a full nine characters.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: fix it

https://tbpl.mozilla.org/?tree=Try&rev=5095ce6e2f05

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

obviously I forgot a printf in it, I will remove it if the rest of the patch is OK.

Comment 5

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=4835dc9b8fc7

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/4835dc9b8fc7